Skip to content

feat(node-experimental): Move errorHandler #10728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 19, 2024

Also stop exporting requestHandler, as that should be handled bu the otel http instrumentation.

I also fixed the otel stuff to properly take care of sessions.

@mydea mydea requested review from lforst and AbhiPrasad February 19, 2024 15:50
@mydea mydea self-assigned this Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.84 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.1 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.02 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.67 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.28 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.2 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.18 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.18 KB (0%)
@sentry/browser - Webpack (gzipped) 22.43 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.7 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.62 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.76 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 213.11 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.74 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.23 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.9 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.43 KB (0%)
@sentry/react - Webpack (gzipped) 22.46 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.89 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 50.1 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.15 KB (0%)

Also stop exporting `requestHandler`, as that should be handled bu the otel http instrumentation.

I also fixed the otel stuff to properly take care of sessions.
@mydea mydea force-pushed the fn/node-experimental-handlers branch from ee2455c to 7cdbef2 Compare February 20, 2024 10:16
@mydea mydea merged commit a02aa00 into develop Feb 20, 2024
@mydea mydea deleted the fn/node-experimental-handlers branch February 20, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants