Skip to content

feat(build): Allow passing Sucrase options for rollup #10747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 20, 2024

This allows you to configure Sucrase for rollup bundles.

Needed for our work on the Feedback screenshotting feature as we want to use Preact + JSX in the project. (ref: #10590)

Example of how this will be used: 0395331

Copy link
Contributor

github-actions bot commented Feb 20, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.85 KB (-0.07% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 69.11 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 73.04 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.67 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.32 KB (-0.08% 🔽)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.22 KB (-0.08% 🔽)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.15 KB (-0.12% 🔽)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.15 KB (-0.13% 🔽)
@sentry/browser - Webpack (gzipped) 22.41 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 76.19 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.69 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.66 KB (-0.07% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.76 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 212.99 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 101.71 KB (-0.09% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74.2 KB (-0.13% 🔽)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.94 KB (-0.07% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.41 KB (-0.08% 🔽)
@sentry/react - Webpack (gzipped) 22.45 KB (-0.1% 🔽)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 86.92 KB (-0.06% 🔽)
@sentry/nextjs Client - Webpack (gzipped) 50.14 KB (-0.05% 🔽)
@sentry-internal/feedback - Webpack (gzipped) 17.16 KB (0%)

This allows you to configure Sucrase for rollup bundles.

Needed for our work on the Feedback screenshotting feature as we want to use Preact + JSX in the project. (ref: #10590)
@billyvg billyvg force-pushed the feat-build-allow-options-to-sucrase branch from 4d400d6 to 867ab74 Compare March 11, 2024 15:35
@billyvg billyvg marked this pull request as ready for review March 11, 2024 15:59
@billyvg billyvg requested a review from Lms24 March 11, 2024 16:00
@billyvg billyvg merged commit 7fbc20c into develop Mar 12, 2024
@billyvg billyvg deleted the feat-build-allow-options-to-sucrase branch March 12, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants