Skip to content

ref(node): Align semantic attribute handling #10827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

ref(node): Align semantic attribute handling #10827

merged 2 commits into from
Feb 28, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 27, 2024

Also stop clearing out sentry attributes, we don't actually want that (except for the parent sampled stuff for now).

@mydea mydea requested review from AbhiPrasad and s1gr1d February 27, 2024 16:22
@mydea mydea self-assigned this Feb 27, 2024
Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Also stop clearing out sentry attributes, we don't actually want that (except for the parent sampled stuff for now).
@mydea mydea merged commit e1063f4 into develop Feb 28, 2024
@mydea mydea deleted the fn/potel-clean branch February 28, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants