Skip to content

ref(astro): Put request as SDK processing metadata instead of span data #10840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 28, 2024

This removes usage of deprecated options to startSpan, and removes the trackHeaders option to the astro middleware in favor of using the general request data integration that should pick this up if put on the scope as SDK processing metadata.

@mydea mydea requested review from lforst and Lms24 February 28, 2024 11:41
@mydea mydea self-assigned this Feb 28, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a small entry for this in the migration guide? (the trackHeaders field was requested by two users so I know someone is using it 😅)

@mydea
Copy link
Member Author

mydea commented Feb 28, 2024

I added a migration entry for this!

While doing this, I noticed we should also revisit the defaults for request data integration - there we capture all of this by default 🤔

Also, maybe we can/should remove the custom ip address stuff from astro middleware as well in favor of letting the request data integration do this? But we can do this later... @Lms24

@mydea mydea force-pushed the fn/astro-middleware branch from 5281b42 to 6a37477 Compare February 28, 2024 13:02
@mydea mydea force-pushed the fn/astro-middleware branch from 6a37477 to e513fb4 Compare February 28, 2024 16:24
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Also, maybe we can/should remove the custom ip address stuff from astro middleware as well in favor of letting the request data integration do this?

I have too little context on the request data integration - does it already do this? If yes, let's do it but I don't know if picking up the ip adress from the context passed into the astro middleware works with the integration. We might need to adjust that.

@mydea
Copy link
Member Author

mydea commented Feb 29, 2024

I'll leave the IP address stuff for a follow up! IP addresses are disabled by default in request data, so that needs opt in even today.

@mydea mydea merged commit 60f483e into develop Feb 29, 2024
@mydea mydea deleted the fn/astro-middleware branch February 29, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants