Skip to content

ref(core): Remove status field from Span #10856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 29, 2024
Merged

ref(core): Remove status field from Span #10856

merged 2 commits into from
Feb 29, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 29, 2024

This removes the public field to get/set status on a span/transaction.

@mydea mydea requested review from AbhiPrasad and s1gr1d February 29, 2024 11:39
@mydea mydea self-assigned this Feb 29, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.3 KB (+0.17% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.55 KB (+0.19% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.47 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.1 KB (+0.21% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.78 KB (+0.41% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.78 KB (+0.41% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.96 KB (+0.49% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 30.96 KB (+0.49% 🔺)
@sentry/browser - Webpack (gzipped) 22.23 KB (+0.62% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.71 KB (+0.18% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.39 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.23 KB (+0.41% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.73 KB (+0.6% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.95 KB (+0.1% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.67 KB (+0.21% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.93 KB (+0.39% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.29 KB (+0.35% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.83 KB (+0.18% 🔺)
@sentry/react - Webpack (gzipped) 22.26 KB (+0.62% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.3 KB (+0.14% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.64 KB (+0.25% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.03 KB (0%)

Copy link
Member

@s1gr1d s1gr1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@mydea mydea force-pushed the fn/remove-span-status branch from cd72196 to 166a8b0 Compare February 29, 2024 13:26
@mydea mydea merged commit 25a783b into develop Feb 29, 2024
@mydea mydea deleted the fn/remove-span-status branch February 29, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants