Skip to content

feat(profiling-node): Expose nodeProfilingIntegration #10868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Feb 29, 2024

@JonasBa when you got some time, could you look into actually rewriting this to the new style? Right now a lot of the tests depend on the non-hook based version etc. and I'm not 100% clear on what can/cannot be removed there 😅

The end result should be just having a single nodeProfilingIntegration that receives the client in setup(client) and sets up hooks etc in there!

@mydea mydea requested review from JonasBa and AbhiPrasad February 29, 2024 15:53
@mydea mydea self-assigned this Feb 29, 2024
Copy link
Contributor

github-actions bot commented Feb 29, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.35 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.57 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.51 KB (0%)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.12 KB (0%)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.8 KB (0%)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.8 KB (0%)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.01 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.01 KB (0%)
@sentry/browser - Webpack (gzipped) 22.25 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.79 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.42 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.26 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.76 KB (0%)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.01 KB (0%)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.74 KB (0%)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 74 KB (0%)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.32 KB (0%)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.84 KB (0%)
@sentry/react - Webpack (gzipped) 22.28 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.32 KB (0%)
@sentry/nextjs Client - Webpack (gzipped) 49.66 KB (0%)
@sentry-internal/feedback - Webpack (gzipped) 17.09 KB (0%)

@JonasBa
Copy link
Member

JonasBa commented Feb 29, 2024

@mydea Yeah, will do, sorry I'm just focused on a different task rn. We should be able to just drop the non hook tests, implementation and move on

@mydea mydea force-pushed the fn/node-profiling-integration branch from e253a45 to b7d7642 Compare March 1, 2024 08:20
@mydea mydea merged commit a845a0e into develop Mar 1, 2024
@mydea mydea deleted the fn/node-profiling-integration branch March 1, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants