Skip to content

feat(v8/core): Move addTracingHeadersToFetchRequest and instrumentFetchRequest to core #10918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat(v8/core): Move addTracingHeadersToFetchRequest and instrumentFetchRequest to core #10918

merged 2 commits into from
Mar 5, 2024

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Mar 5, 2024 •
edited
Loading

With this change we should be ready to move browser tracing into the browser package

ref: #9885

@AbhiPrasad AbhiPrasad requested a review from a team March 5, 2024 00:27
@AbhiPrasad AbhiPrasad self-assigned this Mar 5, 2024
@AbhiPrasad AbhiPrasad requested review from mydea and Lms24 and removed request for a team March 5, 2024 00:27
This was referenced Mar 5, 2024
Closed
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.37 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.58 KB (+0.29% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.5 KB (+0.26% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.14 KB (+0.34% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.84 KB (+0.59% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.84 KB (+0.59% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.34 KB (+1.09% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.35 KB (+1.09% 🔺)
@sentry/browser - Webpack (gzipped) 22.56 KB (+1.4% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.45 KB (+0.2% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.1 KB (+0.23% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 32.98 KB (+0.45% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.07 KB (+1.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 210.62 KB (+0.23% 🔺)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.48 KB (+0.49% 🔺)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 71.79 KB (+1.09% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.12 KB (+0.53% 🔺)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.87 KB (+0.29% 🔺)
@sentry/react - Webpack (gzipped) 22.59 KB (+1.42% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.29 KB (+0.23% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.7 KB (+0.41% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.4 KB (+1.79% 🔺)

AbhiPrasad added a commit that referenced this pull request Mar 5, 2024
@AbhiPrasad
feat(v8/tracing): Delete BrowserTracing class (#10919)
3da0839 
With this PR and
#10918 merged, we can
move all of the browser tracing related code into `@sentry/browser`.
That will allow us to delete `@sentry-internal/tracing` and stop
publishing it.

ref #9885
@AbhiPrasad AbhiPrasad merged commit b5f820b into develop Mar 5, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-core-fetch branch March 5, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

@Lms24 Lms24 Lms24 approved these changes

Assignees

@AbhiPrasad AbhiPrasad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AbhiPrasad @mydea @Lms24