Skip to content

fix(types): Add addScopeListener to Scope interface #10952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 6, 2024

getCurrentScope() has been changed to return the Scope interface rather than the Scope class. This means it's no longer possible to access addScopeListener on the returned scope.

This PR adds this method to the interface. I also updated all the jsdocs in the class to use @inheritDoc so these docs aren't duplicated.

Copy link
Contributor

github-actions bot commented Mar 6, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.56 KB (+0.23% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.81 KB (+0.33% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.7 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.35 KB (+0.34% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.04 KB (+0.6% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.04 KB (+0.6% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.36 KB (+0.06% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.37 KB (+0.05% 🔺)
@sentry/browser - Webpack (gzipped) 22.57 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 0 B (removed)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 0 B (removed)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 0 B (removed)
@sentry/browser - ES6 CDN Bundle (gzipped) 0 B (removed)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 0 B (removed)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 0 B (removed)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 0 B (removed)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 0 B (removed)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (+0.26% 🔺)
@sentry/react - Webpack (gzipped) 22.6 KB (+0.05% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.49 KB (+0.23% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.9 KB (+0.4% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.41 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - CDN Bundle (gzipped) 75.63 KB (added)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (gzipped) 67.24 KB (added)
@sentry/browser (incl. Tracing) - CDN Bundle (gzipped) 33.08 KB (added)
@sentry/browser - CDN Bundle (gzipped) 24.01 KB (added)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (minified & uncompressed) 211.02 KB (added)
@sentry/browser (incl. Tracing) - CDN Bundle (minified & uncompressed) 99.82 KB (added)
@sentry/browser - CDN Bundle (minified & uncompressed) 71.76 KB (added)

@timfish timfish requested a review from mydea March 7, 2024 11:15
@AbhiPrasad AbhiPrasad merged commit 04a1ebe into develop Mar 7, 2024
@AbhiPrasad AbhiPrasad deleted the timfish/scope-addScopeListener branch March 7, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants