Skip to content

ref(svelte): Remove startChild deprecations #10956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2024
Merged

ref(svelte): Remove startChild deprecations #10956

merged 2 commits into from
Mar 7, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 7, 2024

ref #10900

@s1gr1d s1gr1d self-assigned this Mar 7, 2024
@s1gr1d s1gr1d mentioned this pull request Mar 7, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 7, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.56 KB (+0.23% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.81 KB (+0.33% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.7 KB (+0.28% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.35 KB (+0.34% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 33.04 KB (+0.6% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 33.04 KB (+0.6% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 31.36 KB (+0.06% 🔺)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 31.37 KB (+0.05% 🔺)
@sentry/browser - Webpack (gzipped) 22.57 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 0 B (removed)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 0 B (removed)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 0 B (removed)
@sentry/browser - ES6 CDN Bundle (gzipped) 0 B (removed)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 0 B (removed)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 0 B (removed)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 0 B (removed)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 0 B (removed)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 69.04 KB (+0.26% 🔺)
@sentry/react - Webpack (gzipped) 22.6 KB (+0.05% 🔺)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.49 KB (+0.23% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.9 KB (+0.4% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.41 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - CDN Bundle (gzipped) 75.63 KB (added)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (gzipped) 67.24 KB (added)
@sentry/browser (incl. Tracing) - CDN Bundle (gzipped) 33.08 KB (added)
@sentry/browser - CDN Bundle (gzipped) 24.01 KB (added)
@sentry/browser (incl. Tracing, Replay) - CDN Bundle (minified & uncompressed) 211.02 KB (added)
@sentry/browser (incl. Tracing) - CDN Bundle (minified & uncompressed) 99.82 KB (added)
@sentry/browser - CDN Bundle (minified & uncompressed) 71.76 KB (added)

@s1gr1d s1gr1d requested a review from mydea March 7, 2024 08:50
mydea
mydea reviewed Mar 7, 2024
View reviewed changes
packages/svelte/src/performance.ts Outdated
});

onMount(() => {
if (!initSpan) return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this again, as a recent PR changed the signature of startInactiveSpan to always return a span :)

@s1gr1d s1gr1d force-pushed the sig-svelte-startChild-to-startInactiveSpan branch from bd3986d to 0845afa Compare March 7, 2024 09:27
@s1gr1d s1gr1d merged commit e9db461 into develop Mar 7, 2024
@s1gr1d s1gr1d deleted the sig-svelte-startChild-to-startInactiveSpan branch March 7, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mydea mydea mydea approved these changes

Assignees

@s1gr1d s1gr1d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s1gr1d @mydea