ref(browser): Update scope.transactionName on pageload and navigation span creation
#10992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
develop
to
lms/feat-core-scopedata-transactionName
size-limit report 📦
|
Lms24
force-pushed
the
lms/feat-core-scopedata-transactionName
branch
from
45b7d13 to
81e048b
Compare
Lms24
force-pushed
the
lms/feat-browser-scope-setTransactionName
branch
from
1852724 to
f8b2005
Compare
Base automatically changed from
lms/feat-core-scopedata-transactionName
to
develop
March 12, 2024 10:41
…on span creation
Lms24
force-pushed
the
lms/feat-browser-scope-setTransactionName
branch
from
2932733 to
6ef628d
Compare
mydea
reviewed
Mar 12, 2024
| @@ -364,6 +364,8 @@ export const browserTracingIntegration = ((_options: Partial<BrowserTracingOptio | |||
| export function startBrowserTracingPageLoadSpan(client: Client, spanOptions: StartSpanOptions): Span | undefined { | |||
| client.emit('startPageLoadSpan', spanOptions); | |||
|
|
|||
| getCurrentScope().setTransactionName(spanOptions.name); | |||
There was a problem hiding this comment.
I wonder now, if that should possibly go on the isolation scope 🤔 (generally for all our auto-instrumentation). Has up-and downsides... probably it's fine this way, just thinking out loud!
There was a problem hiding this comment.
yeah, I think in the browser it doesn't matter that much, given we're not automatically forking scopes (afaik) 🤔
I think on the server, the isolation scope makes a lot of sense since it generally lasts as long as a request, no?
mydea
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #10991
This PR updates the transaction name on the scope in the default
browserTracingIntegrationand wheneverstartBrowserTracingNavigationSpanandstartBrowserTracingPageLoadSpanare called from higher-level SDKs' integrations.In a follow-up PR, I'm going to make the same update in our individual
browserTracingIntegrations whenever we have access to a parameterized transaction name.ref #10846