-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(v8/bun): Update @sentry/bun to use OTEL node #10997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Very confused why this error is happening. Cache issue? 🤔 |
Run a I've had this a few times recently and for me it was caused by a Rollup bug where |
Well TIL about this sentry-javascript/packages/bun/rollup.npm.config.mjs Lines 5 to 6 in 0caddec
I assume that is what is causing issues. |
94b8789
to
815832c
Compare
6c74347
to
e8fc0cf
Compare
@@ -8,6 +7,9 @@ import * as SentryRemix from '@sentry/remix'; | |||
import * as SentryServerless from '@sentry/serverless'; | |||
import * as SentrySvelteKit from '@sentry/sveltekit'; | |||
|
|||
// Using CJS export for Bun SDK | |||
const SentryBun = require('@sentry/bun'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why CI is failing, trying this to see if it helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was timing out in CI for me yesterday. I tried it locally and it passed and then tried for a 4th time in CI and it passed there too 🤔
Found the bug! I was accidently importing |
662a7e6
to
2493d65
Compare
ref #9956
Given Bun is just a wrapper over Node, we should be good to go with just these changes.