Skip to content

fix(types): Remove usage of allowSyntheticDefaultImports #11073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 13, 2024

The TypeScript docs say

allowSyntheticDefaultImports without esModuleInterop should be avoided. It changes the compiler’s checking behavior without changing the code emitted by tsc, allowing potentially unsafe JavaScript to be emitted. Additionally, the checking changes it introduces are an incomplete version of the ones introduced by esModuleInterop.

@timfish timfish force-pushed the timfish/remove-allowSyntheticDefaultImports branch from f1403a9 to 6a1c3e9 Compare March 13, 2024 09:28
@AbhiPrasad AbhiPrasad merged commit 39360d9 into develop Mar 13, 2024
@AbhiPrasad AbhiPrasad deleted the timfish/remove-allowSyntheticDefaultImports branch March 13, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants