Skip to content

docs: More node docs #11076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2024
Merged

docs: More node docs #11076

merged 3 commits into from
Mar 13, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 13, 2024

Some more node docs for v8, including:

  • How to add custom OTEL instrumentation
  • How to use with custom OTEL setup
  • How to setup non-framework node apps

@mydea mydea requested review from lforst, Lms24 and s1gr1d March 13, 2024 09:32
@mydea mydea self-assigned this Mar 13, 2024
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: I think it's good that we write down these changes but I'm curious if we're considering moving this doc in some capacity to sentry docs?

});
```

### Using a Custom OpenTelemetry Setup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to adjust more or less all the node docs, eventually 😬 so yes!

@mydea
Copy link
Member Author

mydea commented Mar 13, 2024

General comment: I think it's good that we write down these changes but I'm curious if we're considering moving this doc in some capacity to sentry docs?

Definitely! It's a bit of a tricky place because we can't really update them yet because the new stuff is not stable 😬 So I'd keep docs here for now, so we have something to point people to who want to try out the new stuff. And when we come close to being stable (e.g. beta territory), we can start to move these into sentry-docs proper, I'd say?

@Lms24
Copy link
Member

Lms24 commented Mar 13, 2024

Sounds good! When we're ready, we can also open PRs in docs before we go stable with v8 and only merge them afterwards. But it def makes sense to have something to point people to in the meantime. Thanks!

@mydea mydea merged commit a20bf74 into develop Mar 13, 2024
@mydea mydea deleted the fn/moar-node-docs branch March 13, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants