feat(nextjs): Bump minimum required Next.js version to 13.2.0
#11097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
reviewed
Mar 14, 2024
There was a problem hiding this comment.
We can remove Node 14 from the matrix now -
sentry-javascript/.github/workflows/build.yml
Line 542 in 0f1ea2f
| }, | ||
| "peerDependencies": { | ||
| "next": "^10.0.8 || ^11.0 || ^12.0 || ^13.0 || ^14.0", | ||
| "next": "^13.2.0 || ^14.0", |
There was a problem hiding this comment.
IMO we should make this 14.1.3 for vercel/next.js#61194
Suggested change
| "next": "^13.2.0 || ^14.0", | |
| "next": "^13.2.0 || ^14.1.3", |
There was a problem hiding this comment.
I don't understand how that would be useful. Can you elaborate? We still have to maintain anything pre 14.1.3.
There was a problem hiding this comment.
Well if we make 14.1.3 the minimum for v14, we don't have to maintain anything pre 14.1.3. It incentivizes people to use the framework version that works best for the SDK, but I can also see how it introduces friction.
AbhiPrasad
approved these changes
Mar 14, 2024
lforst
force-pushed
the
lforst-min-nextjs-version
branch
from
4b01add to
a0be4c7
Compare
…to lforst-min-nextjs-version
This reverts commit 2c6020b.
size-limit report 📦
|
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #9838
Bumps the
nextpeer dependency to13.2.0and removes integration tests that test versions below that version.