fix(build): Ensure tree shaking works properly for ESM output #11122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
timfish
reviewed
Mar 15, 2024
Apparently, webpack looks at `sideEffects` in the generated package.json, and based on this does not tree shake correctly :grimace:
mydea
force-pushed
the
fn/fix-treeshaking
branch
from
4ae46d7 to
61bbdde
Compare
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…try#11122) Apparently, webpack looks at `sideEffects` in the generated package.json, and based on this does not tree shake correctly 😬 I also bumped webpack (one of the things I tried while debugging this...). This now puts the original `sideEffects` value from the original `package.json` and puts it into the esm package.json.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently, webpack looks at
sideEffectsin the generated package.json, and based on this does not tree shake correctly 😬I also bumped webpack (one of the things I tried while debugging this...).
This now puts the original
sideEffectsvalue from the originalpackage.jsonand puts it into the esm package.json.