Skip to content

ci: Fix size limit action base upload #11124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2024
Merged

ci: Fix size limit action base upload #11124

merged 1 commit into from
Mar 15, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 15, 2024

Noticed this is failing e.g. https://github.com/getsentry/sentry-javascript/actions/runs/8294578489/job/22700116991, it was an incorrect check: if there is no comparison branch, we don't need a PR.

@mydea mydea requested review from lforst, Lms24 and s1gr1d March 15, 2024 10:49
@mydea mydea self-assigned this Mar 15, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 82.98 KB (added)
@sentry/browser (incl. Tracing, Replay) 78.5 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 81.82 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 72.09 KB (added)
@sentry/browser (incl. Tracing) 78.5 KB (added)
@sentry/browser (incl. browserTracingIntegration) 78.5 KB (added)
@sentry/browser (incl. feedbackIntegration) 76.45 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 76.64 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 76.65 KB (added)
@sentry/browser (incl. sendFeedback) 72.52 KB (added)
@sentry/browser 71.95 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 76.62 KB (added)
CDN Bundle (incl. Tracing, Replay) 71.48 KB (added)
CDN Bundle (incl. Tracing) 37.82 KB (added)
CDN Bundle 25.68 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 224.12 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 114.06 KB (added)
CDN Bundle - uncompressed 75.9 KB (added)
@sentry/react (incl. Tracing, Replay) 80.46 KB (added)
@sentry/react 73.93 KB (added)

@mydea mydea merged commit 7e2c5f1 into develop Mar 15, 2024
@mydea mydea deleted the fn/fix-size-limit-push branch March 15, 2024 11:14
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Noticed this is failing e.g.
https://github.com/getsentry/sentry-javascript/actions/runs/8294578489/job/22700116991,
it was an incorrect check: if there is no comparison branch, we don't
need a PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants