-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(aws): Add OTEL based integrations #11548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
67e3afb
to
298b073
Compare
mydea
reviewed
Apr 11, 2024
AbhiPrasad
added a commit
that referenced
this pull request
Apr 18, 2024
Adds `addOpenTelemetryInstrumentation`, a helper that can be used to dynamically register OpenTelemetry instrumentation. This helps unblock work on #11548 The helper itself is quite small: ```ts export function addOpenTelemetryInstrumentation( instrumentation: InstrumentationOption | InstrumentationOption[], ): void { registerInstrumentations({ instrumentations: Array.isArray(instrumentation) ? instrumentation : [instrumentation], }); } ``` and is designed to accept either a standalone instrumentation or an array of instrumentations. This gives users a ton of flexibility into usage!
2c29668
to
7538f3b
Compare
size-limit report 📦
|
mydea
approved these changes
Apr 19, 2024
4c892df
to
6947ed2
Compare
6947ed2
to
5483d3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #11066
ref #10976
resolves #8575 and resolves #9839 because otel instrumentation supports aws sdk v2 and v3
resolves #11101