Skip to content

feat(aws): Add OTEL based integrations #11548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Conversation

AbhiPrasad
Copy link
Member

ref #11066
ref #10976

resolves #8575 and resolves #9839 because otel instrumentation supports aws sdk v2 and v3

resolves #11101

@AbhiPrasad AbhiPrasad self-assigned this Apr 11, 2024
@AbhiPrasad AbhiPrasad force-pushed the abhi-aws-serverless-esm branch from 67e3afb to 298b073 Compare April 11, 2024 00:54
@AbhiPrasad AbhiPrasad marked this pull request as ready for review April 11, 2024 01:45
AbhiPrasad added a commit that referenced this pull request Apr 18, 2024
Adds `addOpenTelemetryInstrumentation`, a helper that can be used to
dynamically register OpenTelemetry instrumentation. This helps unblock
work on #11548

The helper itself is quite small:

```ts
export function addOpenTelemetryInstrumentation(
  instrumentation: InstrumentationOption | InstrumentationOption[],
): void {
  registerInstrumentations({
    instrumentations: Array.isArray(instrumentation) ? instrumentation : [instrumentation],
  });
}
```

and is designed to accept either a standalone instrumentation or an
array of instrumentations. This gives users a ton of flexibility into
usage!
@AbhiPrasad AbhiPrasad force-pushed the abhi-aws-serverless-esm branch from 2c29668 to 7538f3b Compare April 18, 2024 16:18
@AbhiPrasad AbhiPrasad requested a review from mydea April 18, 2024 16:22
Copy link
Contributor

github-actions bot commented Apr 18, 2024

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (0%)
@sentry/browser (incl. Tracing) 32.64 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.92 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.32 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 71.74 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.14 KB (0%)
@sentry/browser (incl. Feedback) 37.78 KB (0%)
@sentry/browser (incl. sendFeedback) 26.45 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.93 KB (0%)
@sentry/react 24.35 KB (0%)
@sentry/react (incl. Tracing) 35.54 KB (0%)
@sentry/vue 25.25 KB (0%)
@sentry/vue (incl. Tracing) 34.4 KB (0%)
@sentry/svelte 21.79 KB (0%)
CDN Bundle 23.97 KB (0%)
CDN Bundle (incl. Tracing) 33.88 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.41 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 83.22 KB (0%)
CDN Bundle - uncompressed 70.62 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 100.67 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.08 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 256.39 KB (0%)
@sentry/nextjs (client) 34.77 KB (0%)
@sentry/sveltekit (client) 33.13 KB (0%)
@sentry/node 154.4 KB (0%)

@AbhiPrasad AbhiPrasad force-pushed the abhi-aws-serverless-esm branch from 6947ed2 to 5483d3b Compare April 22, 2024 16:03
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) April 22, 2024 16:27
@AbhiPrasad AbhiPrasad merged commit 144a5f0 into develop Apr 22, 2024
96 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-aws-serverless-esm branch April 22, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants