Skip to content

fix(nextjs): Escape Next.js' OpenTelemetry instrumentation #11625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 16, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented Apr 16, 2024

Separates Sentry traces from Next.js internal opentelemetry traces.

Next.js spans are currently too inaccurate for us to be used.

Copy link
Contributor

github-actions bot commented Apr 16, 2024

size-limit report 📦

Path Size
@sentry/browser 22.16 KB (0%)
@sentry/browser (incl. Tracing) 31.77 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.08 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.49 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.9 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.79 KB (0%)
@sentry/browser (incl. Feedback) 35.71 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.71 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.74 KB (0%)
@sentry/browser (incl. sendFeedback) 26.95 KB (0%)
@sentry/react 24.84 KB (0%)
@sentry/react (incl. Tracing) 34.66 KB (0%)
@sentry/vue 25.72 KB (0%)
@sentry/vue (incl. Tracing) 33.48 KB (0%)
@sentry/svelte 22.28 KB (0%)
CDN Bundle 24.47 KB (0%)
CDN Bundle (incl. Tracing) 32.99 KB (0%)
CDN Bundle (incl. Tracing, Replay) 66.6 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.81 KB (0%)
CDN Bundle - uncompressed 72.9 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 99.01 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 208.67 KB (0%)
@sentry/nextjs (client) 34.03 KB (0%)
@sentry/sveltekit (client) 32.26 KB (0%)
@sentry/node 120.17 KB (0%)

@lforst lforst marked this pull request as ready for review April 16, 2024 13:36
@lforst lforst requested a review from mydea April 16, 2024 13:36
@lforst lforst merged commit 44bc6cf into develop Apr 16, 2024
66 checks passed
@lforst lforst deleted the lforst-no-nextjs-spans branch April 16, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants