test(ci): Reduce flaky test detector assumed average test runtime #11676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
requested review from
a team,
AbhiPrasad and
s1gr1d
and removed request for
a team
mydea
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked in the last couple of PRs where added integration tests how long our flaky test detector usually runs. Seems like we average somewhere around 18 minutes. Which is generally fine but our target is 30mins runtime. The reason for the "short" runs is that we assume an average runtime of 3s per test. Which apparently is a bit too long (this actually surprised me). Let's try reduce it to 2s and see if we get closer. We can always revert if we overshoot the time budget in the future.
More runs => less ❄️ 🤞