Skip to content

fix(nextjs): Do not sample next spans if they have remote parent #11680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 18, 2024

This hopefully fixes this, not sure how to write a test for this (?) but we can add one later as well...

@mydea mydea requested a review from lforst April 18, 2024 11:34
@mydea mydea self-assigned this Apr 18, 2024
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (0%)
@sentry/browser (incl. Tracing) 31.4 KB (-0.18% 🔽)
@sentry/browser (incl. Tracing, Replay) 66.73 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 60.14 KB (-0.09% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.57 KB (-0.08% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.44 KB (-0.08% 🔽)
@sentry/browser (incl. Feedback) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.28 KB (0%)
@sentry/browser (incl. sendFeedback) 26.46 KB (0%)
@sentry/react 24.35 KB (0%)
@sentry/react (incl. Tracing) 34.31 KB (-0.18% 🔽)
@sentry/vue 25.2 KB (0%)
@sentry/vue (incl. Tracing) 33.12 KB (-0.19% 🔽)
@sentry/svelte 21.79 KB (0%)
CDN Bundle 24.03 KB (0%)
CDN Bundle (incl. Tracing) 32.71 KB (-0.16% 🔽)
CDN Bundle (incl. Tracing, Replay) 66.37 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.57 KB (-0.04% 🔽)
CDN Bundle - uncompressed 70.86 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 97.51 KB (-0.09% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 207.17 KB (-0.05% 🔽)
@sentry/nextjs (client) 33.64 KB (-0.17% 🔽)
@sentry/sveltekit (client) 31.9 KB (-0.19% 🔽)
@sentry/node 155.86 KB (+0.01% 🔺)

@mydea mydea merged commit b05bfd9 into develop Apr 18, 2024
63 checks passed
@mydea mydea deleted the fn/fix-next-if-remote-sampled branch April 18, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants