Skip to content

ci(auto-release): Allow pre-releases in auto release #11769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Apr 24, 2024

addition to #11655

Only the first regex group was used for the version variable which didn't allow pre-releases in the changelog.

@s1gr1d s1gr1d requested review from lforst and Lms24 April 24, 2024 11:00
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (0%)
@sentry/browser (incl. Tracing) 32.63 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.98 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.37 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.02 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.21 KB (0%)
@sentry/browser (incl. Feedback) 37.76 KB (0%)
@sentry/browser (incl. sendFeedback) 26.43 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.91 KB (0%)
@sentry/react 24.33 KB (0%)
@sentry/react (incl. Tracing) 35.53 KB (0%)
@sentry/vue 25.27 KB (0%)
@sentry/vue (incl. Tracing) 34.38 KB (0%)
@sentry/svelte 21.77 KB (0%)
CDN Bundle 23.95 KB (0%)
CDN Bundle (incl. Tracing) 33.89 KB (0%)
CDN Bundle (incl. Tracing, Replay) 67.61 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 83.44 KB (0%)
CDN Bundle - uncompressed 70.56 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 100.57 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.18 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 256.49 KB (0%)
@sentry/nextjs (client) 34.75 KB (0%)
@sentry/sveltekit (client) 33.13 KB (0%)
@sentry/node 152.87 KB (+0.03% 🔺)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's give it a try 👍

@s1gr1d s1gr1d merged commit de98428 into develop Apr 24, 2024
96 checks passed
@s1gr1d s1gr1d deleted the sig/auto-release-version branch April 24, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants