-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(node) refactor contextlines to use readline #12221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 18 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
2d042a2
ref(node): use readline for context lines
JonasBa 1fc2544
test(node): contextline tests
JonasBa b0df967
test(node): contextline tests
JonasBa 3a785bc
ref(node): contextlines cache attempt
JonasBa 28f576f
ref(node) exclude other contextlines extensions
JonasBa 2cfda9b
test(node) fix contextlines test
JonasBa db2df8d
fix scoped test
JonasBa 2be28a5
lint
JonasBa 93e8173
fix regexp danger warning
JonasBa a949d73
Merge branch 'develop' into jb/node/contextlines-memory
JonasBa 584dad2
strict undefined check
JonasBa 00fd3fc
reshuffle order
JonasBa 6588673
test adding error handler on input stream
JonasBa 96a617e
lint
JonasBa b4a51f6
fix duplicate reads on stream error
JonasBa 421178e
fix duplicate reads on stream error
JonasBa 306a11b
add emplace
JonasBa 0dca6c5
fix(node) last line is not picked up as it does not include \n
JonasBa dea113b
ref(contexlines) use ordered startsWith instead of regexp and store c…
JonasBa e684eb6
Merge branch 'develop' into jb/node/contextlines-memory
JonasBa 9af7dfc
ref(node) remove all but cache set snipline occurences
JonasBa 83a8d05
Merge branch 'develop' into jb/node/contextlines-memory
JonasBa 17dea5b
Merge branch 'develop' into jb/node/contextlines-memory
JonasBa 2e3fe8f
Merge branch 'develop' into jb/node/contextlines-memory
JonasBa eecbf5f
Merge branch 'develop' into jb/node/contextlines-memory
JonasBa e79dac2
fix(contextlines) update type assertions
JonasBa ef1fa79
fix(contextlines) use runtime checks instead
JonasBa cc4305a
ref(node) fix types in tests
JonasBa bd35821
test(node) fix wrong type assertion
JonasBa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.