fix(feedback): Fix form width on mobile devices #13068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On mobile devices, the form looked narrow due to the unspecified value of the css variable --form-width. I set it to 100% for mobile devices and this stretched the form to the full width (see before/after screenshots).
artzhookov
changed the title
virtual-marat
approved these changes
Jul 26, 2024
c298lee
reviewed
Jul 26, 2024
| @@ -111,7 +111,7 @@ const FORM = ` | |||
|
|
|||
| @media (max-width: 600px) { | |||
| .form__right { | |||
| width: auto; | |||
| --form-width: 100%; | |||
There was a problem hiding this comment.
Suggested change
| --form-width: 100%; | |
| width: var(--form-width, 100%); |
There was a problem hiding this comment.
Thank you, you're right, it's better this way!
But I corrected the css a little more and set flex: 0 0 auto.
In this case, if width is specified, it will be used.
Minus one copy-paste env().
Improve css by using flex-basis: auto and width
c298lee
approved these changes
Sep 17, 2024
mydea
pushed a commit
that referenced
this pull request
Sep 18, 2024
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #13068 Co-authored-by: c298lee <[email protected]>
|
@artzhookov thanks for the PR! This was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mobile devices, the form looked narrow due to the unspecified value of the css variable --form-width. I set it to 100% for mobile devices and this stretched the form to the full width (see before/after screenshots).
before:
after:
