feat(replay): Add experimental option to allow for a checkout every 6 minutes #13069
Conversation
size-limit report 📦
|
billyvg
force-pushed
the
feat-replay-add-experimental-option-checkout-every
branch
from
48c7dbc to
e19f4fc
Compare
Just for understanding sake, "increase the size of replays" --> does this refer to the size sent over the network, or the size saved at Sentry (or both)? 😅 |
Both - snapshots will generally be larger and has "duplicate" data which end user will need to send. It'll also be saved to Sentry as part of the replay. |
| // | ||
| // `isCheckout` is always true, but want to be explicit that it should | ||
| // only be added for checkouts | ||
| addSettingsEvent(replay, isCheckout); | ||
| if (session && session.segmentId === 0) { |
There was a problem hiding this comment.
I think we already guard this in the addSettingsEvent method? If we guard it here we can remove that check from there instead!
There was a problem hiding this comment.
Ahh, let's keep the guard in there, in case we end up calling addSettingsEvent elsewhere.
… minutes Including more checkouts will improve replayer scrubbing since it will reduce the number of mutations that need to be processed (especially for longer replays). The downside is that it will increase the size of replays since we will have up to 9 more snapshots per replay (max replay duration is 60 minutes / 6 minute checkouts).
billyvg
force-pushed
the
feat-replay-add-experimental-option-checkout-every
branch
from
687d287 to
9014dbc
Compare
billyvg
deleted the
feat-replay-add-experimental-option-checkout-every
branch
Including more checkouts will improve replayer scrubbing since it will reduce the number of mutations that need to be processed (especially for longer replays). The downside is that it will increase the size of replays since we will have up to 9 more snapshots per replay (max replay duration is 60 minutes / 6 minute checkouts).