ref(profiling): Conditionally shim cjs globals #13267
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lforst
changed the title
AbhiPrasad
reviewed
Sep 4, 2024
JonasBa
force-pushed
the
jb/profiling/conditional-shim
branch
from
96bdbdf to
f1f9bd4
Compare
AbhiPrasad
reviewed
Sep 9, 2024
|
@AbhiPrasad mind taking another look, I added the check to run experimental modules and bumped to v22 of nodejs for profiling e2e tests |
AbhiPrasad
approved these changes
Sep 10, 2024
| @@ -1168,7 +1168,7 @@ jobs: | |||
| - name: Set up Node | |||
| uses: actions/setup-node@v4 | |||
| with: | |||
| node-version-file: 'dev-packages/e2e-tests/package.json' | |||
There was a problem hiding this comment.
I'm a little hesitant about this because it means that CI runs differently than local - but I guess we can try this out, cc @mydea
There was a problem hiding this comment.
I guess it is OK - this is just for the e2e tests, we do not test if this works in node 18 then, not sure how important this is to us.
|
Thanks for the reviews @AbhiPrasad @mydea! |
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shims should only be applied if the globals are not present, else it results in double decl and a runtime error. The profiling SDK should gracefully handle env where the shims are already provided.
I couldn't find a way to modify the shim as it is hardcoded in the plugin we are using so I went with the replace plugin approach and a placeholder value #poormansmacros.
Fixes #13259