-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ci: Streamline CI browser playwright tests #13276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
.github/workflows/build.yml
Outdated
@@ -528,7 +528,7 @@ jobs: | |||
run: yarn lerna run test --scope @sentry/profiling-node | |||
|
|||
job_browser_playwright_tests: | |||
name: Playwright (${{ matrix.bundle }}${{ matrix.shard && format(' {0}/{1}', matrix.shard, matrix.shards) || ''}}) Tests | |||
name: PW ${{ matrix.bundle }}${{ matrix.project && matrix.project != 'chromium' && format(' {0}', matrix.project) || ''}}${{ matrix.shard && format(' ({0}/{1})', matrix.shard, matrix.shards) || ''}} Tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd really prefer if we kept Playwright
as PW
is not obvious for an onlooker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I named it back to Playwright ...
!
38e9aa0
to
eccc335
Compare
This PR streamlines our browser integration tests a bit more:
Some data points: