ci: Streamline browser & node unit tests #13307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary.
mydea
requested review from
lforst,
Lms24,
AbhiPrasad,
chargome,
s1gr1d and
andreiborza
Lms24
approved these changes
Aug 12, 2024
chargome
approved these changes
Aug 12, 2024
AbhiPrasad
approved these changes
Aug 12, 2024
| @@ -40,6 +46,7 @@ const SKIP_TEST_PACKAGES: Record<NodeVersion, VersionConfig> = { | |||
| '@sentry/astro', | |||
| '@sentry/nuxt', | |||
| '@sentry/nestjs', | |||
| '@sentry-internal/eslint-plugin-sdk', | |||
There was a problem hiding this comment.
A micro optimization here is to change eslint-plugin-sdk to only run test for whatever the node version of the local env is.
We can effectively treat it as a browser test then.
There was a problem hiding this comment.
actually I guess we should technically run this in multiple node versions, as this is published? 🤔 and actually probably bump the min. node version of this to 16+ as it does not seem to work on 14... 😅 it's internal so I wouild not care about this too much 🤔 WDYT?
Zen-cronic
pushed a commit
to Zen-cronic/sentry-javascript
that referenced
this pull request
Aug 26, 2024
Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary. This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the `browser` list in `ci-unit-tests.ts` to make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of having to keep to separate lists of include/excludes, we now keep this in a single list and invert it when necessary.
This way, we should no longer have problems where tests are either run multiple times, or not in the correct env - just add the test to the
browserlist inci-unit-tests.tsto make sure it is not run in multiple node versions unnecessarily. I also added this step to the new package checklist.