-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ci: Stabilize CI dependency cache key #13401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
const crypto = require('crypto'); | ||
const fs = require('fs'); | ||
const path = require('path'); | ||
|
||
/** | ||
* Build a cache key for the dependencies of the monorepo. | ||
* In addition to the content of the yarn.lock file, we also include | ||
* dependencies of all workspace packages in the cache key. | ||
* This ensures that we get a consistent cache key even if a dependency change does not affect | ||
* the yarn.lock file. | ||
*/ | ||
function outputDependencyCacheKey() { | ||
const lockfileContent = fs.readFileSync(path.join(process.cwd(), 'yarn.lock'), 'utf8'); | ||
|
||
const hashParts = [lockfileContent]; | ||
|
||
const packageJson = require(path.join(process.cwd(), 'package.json')); | ||
|
||
const workspacePackages = packageJson.workspaces || []; | ||
|
||
// Get the package name (e.g. @sentry/browser) of all workspace packages | ||
// we want to ignore their version numbers later | ||
const workspacePackageNames = getWorkspacePackageNames(workspacePackages); | ||
|
||
// Add the dependencies of the workspace itself | ||
hashParts.push(getNormalizedDependencies(packageJson, workspacePackageNames)); | ||
|
||
// Now for each workspace package, add the dependencies | ||
workspacePackages.forEach(workspace => { | ||
const packageJsonPath = path.join(process.cwd(), workspace, 'package.json'); | ||
const packageJson = require(packageJsonPath); | ||
hashParts.push(getNormalizedDependencies(packageJson, workspacePackageNames)); | ||
}); | ||
|
||
const hash = crypto.createHash('md5').update(hashParts.join('\n')).digest('hex'); | ||
// We log the output in a way that the GitHub Actions can append it to the output | ||
// We prefix it with `dependencies-` so it is easier to identify in the logs | ||
// eslint-disable-next-line no-console | ||
console.log(`hash=dependencies-${hash}`); | ||
} | ||
|
||
function getNormalizedDependencies(packageJson, workspacePackageNames) { | ||
const { dependencies, devDependencies } = packageJson; | ||
|
||
const mergedDependencies = { | ||
...devDependencies, | ||
...dependencies, | ||
}; | ||
|
||
const normalizedDependencies = {}; | ||
|
||
// Sort the keys to ensure a consistent order | ||
Object.keys(mergedDependencies) | ||
.sort() | ||
.forEach(key => { | ||
// If the dependency is a workspace package, ignore the version | ||
// No need to invalidate a cache after every release | ||
const version = workspacePackageNames.includes(key) ? '**workspace**' : mergedDependencies[key]; | ||
normalizedDependencies[key] = version; | ||
}); | ||
|
||
return JSON.stringify(normalizedDependencies); | ||
} | ||
|
||
function getWorkspacePackageNames(workspacePackages) { | ||
return workspacePackages.map(workspace => { | ||
const packageJsonPath = path.join(process.cwd(), workspace, 'package.json'); | ||
const packageJson = require(packageJsonPath); | ||
return packageJson.name; | ||
}); | ||
} | ||
|
||
outputDependencyCacheKey(); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't this mean that we might have outdated internal code in the cache?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the cache key to cache the node_modules folder. So all the workspace packages should not be there at all, so the version should not matter (I think? at least 😅 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 yeah I just wasn't sure how these workspace packages are handled within node modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's a good question 🤔 there are only some symlinks in there, but these should not change I believe between versions. IMHO we can try it and if there are problems we can revisit this particular check - but I'd expect it to be OK. We do capture added internal dependencies, which should be fine I think/hope 😅