feat(node): Add dataloader integration
#13664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/dataloader-integration
branch
from
e95324d to
fb171b0
Compare
onurtemizkan
changed the title
dataloader instrumentationdataloader integration
onurtemizkan
requested review from
mydea,
AbhiPrasad and
Lms24
and removed request for
mydea
AbhiPrasad
reviewed
Sep 13, 2024
AbhiPrasad
reviewed
Sep 13, 2024
|
|
||
| const INTEGRATION_NAME = 'Dataloader'; | ||
|
|
||
| export const instrumentDataloader = generateInstrumentOnce(INTEGRATION_NAME, () => new DataloaderInstrumentation({})); |
There was a problem hiding this comment.
I think we should set requireParentSpan to be true by default, and then expose config to change it accordingly, but I'm open to other opinions.
@mydea what do you think?
There was a problem hiding this comment.
Let's set requireParentSpan to be true by default @onurtemizkan. We don't need to expose config for now, we can add that later based on user request.
There was a problem hiding this comment.
Just realised it's also true by default in DataloaderIntegration. Still, passed true from our side, and we can expose it later if we need to.
There was a problem hiding this comment.
this sounds reasonable to me, I guess you rarely want this to be a transaction!
@AbhiPrasad, here's the trace of what we test in the integration tests. Link |
2 tasks
AbhiPrasad
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #13313
Adds integration for
dataloaderusing@opentelemetry/instrumentation-dataloaderon the background.A few notes:
@opentelemetry/instrumentation-dataloader. So, we don't havecache.hit,cache.key,cache.item_sizeand so on, in this integration. I can try to implement those upstream, but if you have another way in mind to access those please let me know.@opentelemetry/instrumentation-dataloaderonly records spans forload,loadManyandbatch, which all arecache.getoperations. There are alsoprime,clear,clearAll. We also can implement those upstream and update the integration in future.