Skip to content

fix(opentelemetry): Prevent span name update overwrites and ensure sentry.source is set correctly #14280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 13, 2024

heavy WIP; tests will fail a lot still

@Lms24 Lms24 changed the title fix(opentelemetry): Prevent span name updatet overwrites and sentry.source is set correctly fix(opentelemetry): Prevent span name update overwrites and sentry.source is set correctly Nov 13, 2024
@Lms24 Lms24 changed the title fix(opentelemetry): Prevent span name update overwrites and sentry.source is set correctly fix(opentelemetry): Prevent span name update overwrites and ensure sentry.source is set correctly Nov 13, 2024
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.77 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.26 KB - -
@sentry/browser (incl. Tracing, Replay) 71.98 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.35 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.31 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.14 KB - -
@sentry/browser (incl. Feedback) 39.93 KB - -
@sentry/browser (incl. sendFeedback) 27.42 KB - -
@sentry/browser (incl. FeedbackAsync) 32.23 KB - -
@sentry/react 25.52 KB - -
@sentry/react (incl. Tracing) 38.22 KB - -
@sentry/vue 26.91 KB - -
@sentry/vue (incl. Tracing) 37.1 KB - -
@sentry/svelte 22.91 KB - -
CDN Bundle 24.13 KB - -
CDN Bundle (incl. Tracing) 37.04 KB - -
CDN Bundle (incl. Tracing, Replay) 71.7 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.05 KB - -
CDN Bundle - uncompressed 70.73 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.9 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.42 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.64 KB - -
@sentry/nextjs (client) 38.33 KB - -
@sentry/sveltekit (client) 35.84 KB - -
@sentry/node 134.36 KB +0.06% +76 B 🔺
@sentry/node - without tracing 96.51 KB +0.06% +54 B 🔺
@sentry/aws-serverless 106.77 KB +0.05% +52 B 🔺

View base workflow run

Copy link

codecov bot commented Nov 13, 2024

❌ 33 Tests Failed:

Tests completed Failed Passed Skipped
651 33 618 27
View the top 3 failed tests by shortest run time
server.test.ts Should record a transaction for route with parameters
Stack Traces | 0.142s run time
server.test.ts:24:5 Should record a transaction for route with parameters
server-transactions.test.ts Sends parameterized transaction name to Sentry
Stack Traces | 0.178s run time
server-transactions.test.ts:8:5 Sends parameterized transaction name to Sentry
server/getServerSideProps.test.ts Should report an error event for errors thrown in getServerSideProps in pages with custom page extensions
Stack Traces | 0.234s run time
getServerSideProps.test.ts:89:5 Should report an error event for errors thrown in getServerSideProps in pages with custom page extensions

To view more test analytics, go to the Test Analytics Dashboard
Got feedback? Let us know on Github

@Lms24
Copy link
Member Author

Lms24 commented Nov 14, 2024

Closing because we discovered some significant problems with this approach. I'll add a writeup here or in #14291 which supersedes this PR in a bit.

@Lms24 Lms24 closed this Nov 14, 2024
@Lms24 Lms24 deleted the lms/fix-node-span-updatename-source-overwrite branch December 3, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant