-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(opentelemetry): Ignore propagation context when not continuing trace #14409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
6cf8609
to
28fbde8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something I noticed but not 100% sure if problematic:
Our startNewTrace
API recycles the propagation context and doesn't set a parent span. So I guess in that case, we'd not take the traceId created from startNewTrace
but create yet another one? Probably that's even fine but it kinda questions the existance of startNewTrace
, right? 😅
Oh I guess it still makes sense when you want to actively start a new trace while there is an active span 🤔
hmm yeah true! But I guess this is still fine in so far as |
28fbde8
to
0ae5a19
Compare
0ae5a19
to
303a7a0
Compare
Let's see how that would even work...
Implements changes on top of #14426