fix(angular): Fall back to element tagName when name is not provided to TraceDirective
#14778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Interesting change, thanks @arturovt! Would be great to get this working but I wanna make sure it works across our supported version range. I'll give this a try in an old NG14 test app of mine but it would be great if you could add a test in our Angular 19 e2e test app: https://github.com/getsentry/sentry-javascript/tree/develop/dev-packages/e2e-tests/test-applications/angular-19
If you don't have time, let me know, then I can take over as well.
Lms24
reviewed
Dec 18, 2024
…ided The `trace` directive should typically be declared on components to validly trace the lifecycle (from `ngOnInit` to `ngAfterViewInit`, when child views are also rendered). If `trace` is mistakenly not provided, we fall back to `tagName`.
arturovt
force-pushed
the
fix/angular-trace-tag
branch
from
2cbed30 to
baf79c5
Compare
Lms24
approved these changes
Dec 23, 2024
Lms24
changed the title
tagName when trace is not providedtagName when trace is not provided
Lms24
changed the title
tagName when trace is not providedtagName when name is not provided to TraceDirective
Lms24
added a commit
that referenced
this pull request
Dec 23, 2024
…d to `TraceDirective` (#14778) The `trace` directive should typically be declared on components to validly trace the lifecycle (from `ngOnInit` to `ngAfterViewInit`, when child views are also rendered). If `trace` is mistakenly not provided, we fall back to `tagName` instead of "unknown component". --------- Co-authored-by: Lukas Stracke <[email protected]>
Lms24
added a commit
that referenced
this pull request
Dec 23, 2024
…ided to `TraceDirective` (#14828) Backport of #14778 --------- Co-authored-by: Artur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tracedirective should typically be declared on components to validly trace the lifecycle (fromngOnInittongAfterViewInit, when child views are also rendered). Iftraceis mistakenly not provided, we fall back totagName.