ref: Rewrite to use optional chaining & add eslint rule

dev-packages/browser-integration-tests/suites/integrations/captureConsole-attachStackTrace/test.ts

@@ -19,10 +19,10 @@ sentryTest(
     const errorEvent = events.find(event => event.message === 'console error');
     const traceEvent = events.find(event => event.message === 'console trace');
     const errorWithErrorEvent = events.find(
-      event => event.exception && event.exception.values?.[0].value === 'console error with error object',
+      event => event.exception?.values?.[0].value === 'console error with error object',
     );
     const traceWithErrorEvent = events.find(
-      event => event.exception && event.exception.values?.[0].value === 'console trace with error object',
+      event => event.exception?.values?.[0].value === 'console trace with error object',
     );
 
     expect(logEvent).toEqual(

dev-packages/browser-integration-tests/suites/integrations/captureConsole/test.ts

@@ -17,10 +17,10 @@ sentryTest('it captures console messages correctly', async ({ getLocalTestUrl, p
   const errorEvent = events.find(event => event.message === 'console error');
   const traceEvent = events.find(event => event.message === 'console trace');
   const errorWithErrorEvent = events.find(
-    event => event.exception && event.exception.values?.[0].value === 'console error with error object',
+    event => event.exception?.values?.[0].value === 'console error with error object',
   );
   const traceWithErrorEvent = events.find(
-    event => event.exception && event.exception.values?.[0].value === 'console trace with error object',
+    event => event.exception?.values?.[0].value === 'console trace with error object',
   );
 
   expect(logEvent).toEqual(

dev-packages/browser-integration-tests/suites/integrations/featureFlags/featureFlags/withScope/test.ts

@@ -22,8 +22,8 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
   const url = await getLocalTestUrl({ testDir: __dirname, skipDsnRouteHandler: true });
   await page.goto(url);
 
-  const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === true);
-  const mainReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === false);
+  const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags?.isForked === true);
+  const mainReqPromise = waitForErrorRequest(page, event => !!event.tags?.isForked === false);
 
   await page.evaluate(() => {
     const Sentry = (window as any).Sentry;

dev-packages/browser-integration-tests/suites/integrations/featureFlags/launchdarkly/withScope/test.ts

@@ -22,8 +22,8 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
   const url = await getLocalTestUrl({ testDir: __dirname, skipDsnRouteHandler: true });
   await page.goto(url);
 
-  const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === true);
-  const mainReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === false);
+  const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags?.isForked === true);
+  const mainReqPromise = waitForErrorRequest(page, event => !!event.tags?.isForked === false);
 
   await page.evaluate(() => {
     const Sentry = (window as any).Sentry;

dev-packages/browser-integration-tests/suites/integrations/featureFlags/openfeature/withScope/test.ts

@@ -22,8 +22,8 @@ sentryTest('Flag evaluations in forked scopes are stored separately.', async ({
   const url = await getLocalTestUrl({ testDir: __dirname, skipDsnRouteHandler: true });
   await page.goto(url);
 
-  const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === true);
-  const mainReqPromise = waitForErrorRequest(page, event => !!event.tags && event.tags.isForked === false);
+  const forkedReqPromise = waitForErrorRequest(page, event => !!event.tags?.isForked === true);
+  const mainReqPromise = waitForErrorRequest(page, event => !!event.tags?.isForked === false);
 
   await page.evaluate(() => {
     const Sentry = (window as any).Sentry;

dev-packages/browser-integration-tests/suites/old-sdk-interop/acs/getCurrentScope/subject.js

@@ -4,7 +4,7 @@ const sentryCarrier = window?.__SENTRY__;
  * Simulate an old pre v8 SDK obtaining the hub from the global sentry carrier
  * and checking for the hub version.
  */
-const res = sentryCarrier.acs && sentryCarrier.acs.getCurrentScope();
+const res = sentryCarrier.acs?.getCurrentScope();
 
 // Write back result into the document
 document.getElementById('currentScope').innerText = res && 'scope';

dev-packages/browser-integration-tests/suites/old-sdk-interop/hub/isOlderThan/subject.js

@@ -4,7 +4,7 @@ const sentryCarrier = window?.__SENTRY__;
  * Simulate an old pre v8 SDK obtaining the hub from the global sentry carrier
  * and checking for the hub version.
  */
-const res = sentryCarrier.hub && sentryCarrier.hub.isOlderThan(7);
+const res = sentryCarrier.hub?.isOlderThan(7);
 
 // Write back result into the document
 document.getElementById('olderThan').innerText = res;

dev-packages/browser-integration-tests/suites/replay/captureReplayOffline/test.ts

@@ -5,7 +5,7 @@ import { getReplayEvent, shouldSkipReplayTest, waitForReplayRequest } from '../.
 
 sentryTest('should capture replays offline', async ({ getLocalTestUrl, page }) => {
   // makeBrowserOfflineTransport is not included in any CDN bundles
-  if (shouldSkipReplayTest() || (process.env.PW_BUNDLE && process.env.PW_BUNDLE.startsWith('bundle'))) {
+  if (shouldSkipReplayTest() || process.env.PW_BUNDLE?.startsWith('bundle')) {
     sentryTest.skip();
   }
 

dev-packages/browser-integration-tests/suites/replay/replayIntegrationShim/test.ts

@@ -7,7 +7,7 @@ sentryTest(
   async ({ getLocalTestUrl, page, forceFlushReplay }) => {
     const bundle = process.env.PW_BUNDLE;
 
-    if (!bundle || !bundle.startsWith('bundle_') || bundle.includes('replay')) {
+    if (!bundle?.startsWith('bundle_') || bundle.includes('replay')) {
       sentryTest.skip();
     }
 

dev-packages/browser-integration-tests/suites/replay/replayShim/test.ts

@@ -7,7 +7,7 @@ sentryTest(
   async ({ getLocalTestUrl, page, forceFlushReplay }) => {
     const bundle = process.env.PW_BUNDLE;
 
-    if (!bundle || !bundle.startsWith('bundle_') || bundle.includes('replay')) {
+    if (!bundle?.startsWith('bundle_') || bundle.includes('replay')) {
       sentryTest.skip();
     }
 

dev-packages/browser-integration-tests/suites/transport/offline/queued/test.ts

@@ -10,7 +10,7 @@ function delay(ms: number) {
 
 sentryTest('should queue and retry events when they fail to send', async ({ getLocalTestUrl, page }) => {
   // makeBrowserOfflineTransport is not included in any CDN bundles
-  if (process.env.PW_BUNDLE && process.env.PW_BUNDLE.startsWith('bundle')) {
+  if (process.env.PW_BUNDLE?.startsWith('bundle')) {
     sentryTest.skip();
   }
 

packages/angular/src/zone.ts

@@ -8,7 +8,7 @@ declare const Zone: any;
 // Therefore, it's advisable to safely check whether the `run` function is
 // available in the `<root>` context.
 // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-const isNgZoneEnabled = typeof Zone !== 'undefined' && Zone.root && Zone.root.run;
+const isNgZoneEnabled = typeof Zone !== 'undefined' && Zone.root?.run;
 
 /**
  * The function that does the same job as `NgZone.runOutsideAngular`.

packages/browser-utils/src/getNativeImplementation.ts

@@ -47,7 +47,7 @@ export function getNativeImplementation<T extends keyof CacheableImplementations
       sandbox.hidden = true;
       document.head.appendChild(sandbox);
       const contentWindow = sandbox.contentWindow;
-      if (contentWindow && contentWindow[name]) {
+      if (contentWindow?.[name]) {
         impl = contentWindow[name] as CacheableImplementations[T];
       }
       document.head.removeChild(sandbox);

packages/browser-utils/src/instrument/dom.ts

@@ -67,7 +67,7 @@ export function instrumentDOM(): void {
     const proto = globalObject[target]?.prototype;
 
     // eslint-disable-next-line no-prototype-builtins
-    if (!proto || !proto.hasOwnProperty || !proto.hasOwnProperty('addEventListener')) {
+    if (!proto?.hasOwnProperty?.('addEventListener')) {
       return;
     }
 
@@ -169,7 +169,7 @@ function shouldSkipDOMEvent(eventType: string, target: SentryWrappedTarget | nul
     return false;
   }
 
-  if (!target || !target.tagName) {
+  if (!target?.tagName) {
     return true;
   }
 

packages/browser-utils/src/metrics/browserMetrics.ts

@@ -97,7 +97,7 @@ export function startTrackingWebVitals({ recordClsStandaloneSpans }: StartTracki
       fidCleanupCallback();
       lcpCleanupCallback();
       ttfbCleanupCallback();
-      clsCleanupCallback && clsCleanupCallback();
+      clsCleanupCallback?.();
     };
   }
 
@@ -300,7 +300,7 @@ interface AddPerformanceEntriesOptions {
 /** Add performance related spans to a transaction */
 export function addPerformanceEntries(span: Span, options: AddPerformanceEntriesOptions): void {
   const performance = getBrowserPerformanceAPI();
-  if (!performance || !performance.getEntries || !browserPerformanceTimeOrigin) {
+  if (!performance?.getEntries || !browserPerformanceTimeOrigin) {
     // Gatekeeper if performance API not available
     return;
   }

packages/browser-utils/src/metrics/cls.ts

@@ -73,7 +73,7 @@ export function trackClsAsStandaloneSpan(): void {
 
     const unsubscribeStartNavigation = client.on('startNavigationSpan', () => {
       _collectClsOnce();
-      unsubscribeStartNavigation && unsubscribeStartNavigation();
+      unsubscribeStartNavigation?.();
     });
 
     const activeSpan = getActiveSpan();
@@ -93,7 +93,7 @@ function sendStandaloneClsSpan(clsValue: number, entry: LayoutShift | undefined,
   const startTime = msToSec((browserPerformanceTimeOrigin || 0) + (entry?.startTime || 0));
   const routeName = getCurrentScope().getScopeData().transactionName;
 
-  const name = entry ? htmlTreeAsString(entry.sources[0] && entry.sources[0].node) : 'Layout shift';
+  const name = entry ? htmlTreeAsString(entry.sources[0]?.node) : 'Layout shift';
 
   const attributes: SpanAttributes = dropUndefinedKeys({
     [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.browser.cls',

packages/browser-utils/src/metrics/instrument.ts

@@ -201,7 +201,7 @@ export function addPerformanceInstrumentationHandler(
 function triggerHandlers(type: InstrumentHandlerType, data: unknown): void {
   const typeHandlers = handlers[type];
 
-  if (!typeHandlers || !typeHandlers.length) {
+  if (!typeHandlers?.length) {
     return;
   }
 

packages/browser-utils/src/metrics/utils.ts

@@ -106,7 +106,7 @@ export function startStandaloneWebVitalSpan(options: StandaloneWebVitalSpanOptio
     // Web vital score calculation relies on the user agent to account for different
     // browsers setting different thresholds for what is considered a good/meh/bad value.
     // For example: Chrome vs. Chrome Mobile
-    'user_agent.original': WINDOW.navigator && WINDOW.navigator.userAgent,
+    'user_agent.original': WINDOW.navigator?.userAgent,
 
     ...passedAttributes,
   };

packages/browser-utils/src/metrics/web-vitals/lib/getNavigationEntry.ts

@@ -19,8 +19,7 @@ import { WINDOW } from '../../../types';
 // sentry-specific change:
 // add optional param to not check for responseStart (see comment below)
 export const getNavigationEntry = (checkResponseStart = true): PerformanceNavigationTiming | void => {
-  const navigationEntry =
-    WINDOW.performance && WINDOW.performance.getEntriesByType && WINDOW.performance.getEntriesByType('navigation')[0];
+  const navigationEntry = WINDOW.performance?.getEntriesByType?.('navigation')[0];
   // Check to ensure the `responseStart` property is present and valid.
   // In some cases no value is reported by the browser (for
   // privacy/security reasons), and in other cases (bugs) the value is

packages/browser-utils/src/metrics/web-vitals/lib/initMetric.ts

@@ -25,9 +25,9 @@ export const initMetric = <MetricName extends MetricType['name']>(name: MetricNa
   let navigationType: MetricType['navigationType'] = 'navigate';
 
   if (navEntry) {
-    if ((WINDOW.document && WINDOW.document.prerendering) || getActivationStart() > 0) {
+    if (WINDOW.document?.prerendering || getActivationStart() > 0) {
       navigationType = 'prerender';
-    } else if (WINDOW.document && WINDOW.document.wasDiscarded) {
+    } else if (WINDOW.document?.wasDiscarded) {
       navigationType = 'restore';
     } else if (navEntry.type) {
       navigationType = navEntry.type.replace(/_/g, '-') as MetricType['navigationType'];

packages/browser-utils/src/metrics/web-vitals/lib/interactions.ts

@@ -113,7 +113,7 @@ export const processInteractionEntry = (entry: PerformanceEventTiming) => {
         existingInteraction.latency = entry.duration;
       } else if (
         entry.duration === existingInteraction.latency &&
-        entry.startTime === (existingInteraction.entries[0] && existingInteraction.entries[0].startTime)
+        entry.startTime === existingInteraction.entries[0]?.startTime
       ) {
         existingInteraction.entries.push(entry);
       }

packages/browser-utils/src/metrics/web-vitals/lib/onHidden.ts

@@ -32,7 +32,7 @@ export interface OnHiddenCallback {
 // simulate the page being hidden.
 export const onHidden = (cb: OnHiddenCallback) => {
   const onHiddenOrPageHide = (event: Event) => {
-    if (event.type === 'pagehide' || (WINDOW.document && WINDOW.document.visibilityState === 'hidden')) {
+    if (event.type === 'pagehide' || WINDOW.document?.visibilityState === 'hidden') {
       cb(event);
     }
   };

packages/browser-utils/src/metrics/web-vitals/lib/whenActivated.ts

@@ -17,7 +17,7 @@
 import { WINDOW } from '../../../types';
 
 export const whenActivated = (callback: () => void) => {
-  if (WINDOW.document && WINDOW.document.prerendering) {
+  if (WINDOW.document?.prerendering) {
     addEventListener('prerenderingchange', () => callback(), true);
   } else {
     callback();

packages/browser-utils/src/metrics/web-vitals/lib/whenIdle.ts

@@ -30,7 +30,7 @@ export const whenIdle = (cb: () => void): number => {
   cb = runOnce(cb) as () => void;
   // If the document is hidden, run the callback immediately, otherwise
   // race an idle callback with the next `visibilitychange` event.
-  if (WINDOW.document && WINDOW.document.visibilityState === 'hidden') {
+  if (WINDOW.document?.visibilityState === 'hidden') {
     cb();
   } else {
     handle = rIC(cb);

packages/browser-utils/src/metrics/web-vitals/onTTFB.ts

@@ -30,9 +30,9 @@ export const TTFBThresholds: MetricRatingThresholds = [800, 1800];
  * @param callback
  */
 const whenReady = (callback: () => void) => {
-  if (WINDOW.document && WINDOW.document.prerendering) {
+  if (WINDOW.document?.prerendering) {
     whenActivated(() => whenReady(callback));
-  } else if (WINDOW.document && WINDOW.document.readyState !== 'complete') {
+  } else if (WINDOW.document?.readyState !== 'complete') {
     addEventListener('load', () => whenReady(callback), true);
   } else {
     // Queue a task so the callback runs after `loadEventEnd`.

packages/browser/src/integrations/breadcrumbs.ts

@@ -352,7 +352,7 @@ function _getHistoryBreadcrumbHandler(client: Client): (handlerData: HandlerData
     const parsedTo = parseUrl(to);
 
     // Initial pushState doesn't provide `from` information
-    if (!parsedFrom || !parsedFrom.path) {
+    if (!parsedFrom?.path) {
       parsedFrom = parsedLoc;
     }
 

packages/browser/src/integrations/browserapierrors.ts

@@ -166,7 +166,7 @@ function _wrapEventTarget(target: string): void {
   const proto = globalObject[target]?.prototype;
 
   // eslint-disable-next-line no-prototype-builtins
-  if (!proto || !proto.hasOwnProperty || !proto.hasOwnProperty('addEventListener')) {
+  if (!proto?.hasOwnProperty?.('addEventListener')) {
     return;
   }
 

packages/browser/src/integrations/contextlines.ts

@@ -51,8 +51,8 @@ function addSourceContext(event: Event, contextLines: number): Event {
     return event;
   }
 
-  const exceptions = event.exception && event.exception.values;
-  if (!exceptions || !exceptions.length) {
+  const exceptions = event.exception?.values;
+  if (!exceptions?.length) {
     return event;
   }
 

packages/browser/src/integrations/httpcontext.ts

@@ -1,4 +1,4 @@
-import { defineIntegration } from '@sentry/core';
+import { defineIntegration, getLocationHref } from '@sentry/core';
 import { WINDOW } from '../helpers';
 
 /**
@@ -15,16 +15,20 @@ export const httpContextIntegration = defineIntegration(() => {
       }
 
       // grab as much info as exists and add it to the event
-      const url = (event.request && event.request.url) || (WINDOW.location && WINDOW.location.href);
+      const url = event.request?.url || getLocationHref();
       const { referrer } = WINDOW.document || {};
       const { userAgent } = WINDOW.navigator || {};
 
       const headers = {
-        ...(event.request && event.request.headers),
+        ...event.request?.headers,
         ...(referrer && { Referer: referrer }),
         ...(userAgent && { 'User-Agent': userAgent }),
       };
-      const request = { ...event.request, ...(url && { url }), headers };
+      const request = {
+        ...event.request,
+        ...(url && { url }),
+        headers,
+      };
 
       event.request = request;
     },

packages/browser/src/profiling/integration.ts

@@ -50,8 +50,8 @@ const _browserProfilingIntegration = (() => {
 
         for (const profiledTransaction of profiledTransactionEvents) {
           const context = profiledTransaction?.contexts;
-          const profile_id = context && context['profile'] && context['profile']['profile_id'];
-          const start_timestamp = context && context['profile'] && context['profile']['start_timestamp'];
+          const profile_id = context?.profile?.['profile_id'];
+          const start_timestamp = context?.profile?.['start_timestamp'];
 
           if (typeof profile_id !== 'string') {
             DEBUG_BUILD && logger.log('[Profiling] cannot find profile for a span without a profile context');
@@ -64,7 +64,7 @@ const _browserProfilingIntegration = (() => {
           }
 
           // Remove the profile from the span context before sending, relay will take care of the rest.
-          if (context && context['profile']) {
+          if (context?.profile) {
             delete context.profile;
           }