Skip to content

feat(node): Add server.address to nodejs logs #16006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

AbhiPrasad
Copy link
Member

server.address is the equivalent to server_name we attach to errors and transactions. See the spec for the attribute here: https://getsentry.github.io/sentry-conventions/generated/attributes/server.html#serveraddress

resolves https://linear.app/getsentry/issue/LOGS-32

@AbhiPrasad AbhiPrasad requested a review from a team April 8, 2025 09:35
@AbhiPrasad AbhiPrasad self-assigned this Apr 8, 2025
@AbhiPrasad AbhiPrasad requested review from Lms24 and s1gr1d and removed request for a team April 8, 2025 09:35
Copy link
Contributor

github-actions bot commented Apr 8, 2025

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.26 KB - -
@sentry/browser - with treeshaking flags 23.1 KB - -
@sentry/browser (incl. Tracing) 36.92 KB - -
@sentry/browser (incl. Tracing, Replay) 74.12 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.49 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 78.78 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.58 KB - -
@sentry/browser (incl. Feedback) 39.65 KB - -
@sentry/browser (incl. sendFeedback) 27.88 KB - -
@sentry/browser (incl. FeedbackAsync) 32.65 KB - -
@sentry/react 25.07 KB - -
@sentry/react (incl. Tracing) 38.85 KB - -
@sentry/vue 27.48 KB - -
@sentry/vue (incl. Tracing) 38.65 KB - -
@sentry/svelte 23.29 KB - -
CDN Bundle 24.51 KB - -
CDN Bundle (incl. Tracing) 36.95 KB - -
CDN Bundle (incl. Tracing, Replay) 71.99 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.16 KB - -
CDN Bundle - uncompressed 71.47 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.23 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.52 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.05 KB - -
@sentry/nextjs (client) 40.47 KB - -
@sentry/sveltekit (client) 37.37 KB - -
@sentry/node 143.02 KB +0.02% +25 B 🔺
@sentry/node - without tracing 96.22 KB +0.04% +32 B 🔺
@sentry/aws-serverless 120.56 KB +0.03% +28 B 🔺

View base workflow run

@AbhiPrasad AbhiPrasad merged commit 6c40f4b into develop Apr 8, 2025
108 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-server-address-in-logs branch April 8, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants