feat(nextjs): Add mechanism to withSentry-caught errors
#4046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
kamilogorek
approved these changes
Oct 11, 2021
This was referenced Oct 13, 2021
lobsterkatie
added a commit
that referenced
this pull request
Oct 20, 2021
Though we have an existing `Mechanism` type, we haven't actually been using it in `addExceptionMechanism`. As a result, I didn't catch the fact that the `mechanism` data I added in #4046 was malformed, and therefore being ignored by Sentry. This fixes both of those problems (the not using of the type and the malformed data being sent). Using the correct type also allowed `addExceptionMechanism` to be streamlined quite a bit. Finally, given that the question of what the different attributes and their values actually mean has come up more than once, I conferred with the team, and added a docstring to the type. Hopefully this will help anyone who needs to add `mechanism` data in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the
mechanismvalue fromgenerictowithSentryfor exceptions caught by thewithSentrywrapper.