Skip to content

chore(deps): Upgrade eslint to 7.32.0 #4127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2021
Merged

chore(deps): Upgrade eslint to 7.32.0 #4127

merged 3 commits into from
Nov 10, 2021

Conversation

AbhiPrasad
Copy link
Member

@AbhiPrasad AbhiPrasad commented Nov 5, 2021

Upgrade eslint to 7.32.0 to stay up to date on the dependency. See: https://github.com/eslint/eslint/blob/main/CHANGELOG.md

7.32.0 is the last version minor/patch version before 8.0.0 major bump. Bumping to v8 is too much of a hassle because of potential breaking changes, so sticking with the latest v7 for now.

Also run https://www.npmjs.com/package/yarn-deduplicate to clean up yarn.lock file.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 5, 2021

size-limit report

Path Size
@sentry/browser - CDN Bundle (gzipped) 22.45 KB (+0.01% 🔺)
@sentry/browser - Webpack 23.35 KB (0%)
@sentry/react - Webpack 23.38 KB (0%)
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 29.89 KB (0%)

Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we upgrading to 7.32.0 (and why not another version)? Can we add the reason to the PR description? Linking to the changelog is good to see all the changes, but doesn't tell us why we need the upgrade.

@AbhiPrasad
Copy link
Member Author

Updated the PR descriptions

@AbhiPrasad AbhiPrasad merged commit 23a79ab into master Nov 10, 2021
@AbhiPrasad AbhiPrasad deleted the abhi-eslint-7.32.0 branch November 10, 2021 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants