-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(dev): Unify typescript config files #4178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
dd7615f
3fa9b23
f8bb951
5067883
1faecba
7617041
9b0eaa1
e1e1d91
05d8825
07f32cf
1213493
dd4a01d
0b94f60
5869272
0adf0b3
c570526
dfdc2f3
420c04d
0944502
70002d4
e84063a
6181957
8a37a38
e06e205
4c4d2cc
e15af42
465ec2d
821f543
ccd2ad0
797ce20
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"module": "commonjs", | ||
lobsterkatie marked this conversation as resolved.
Show resolved
Hide resolved
|
||
"outDir": "dist" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.esm.json", | ||
"extends": "./tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"baseUrl": ".", | ||
"outDir": "esm", | ||
"experimentalDecorators": true | ||
}, | ||
"include": ["src/**/*"] | ||
"module": "es6", | ||
"outDir": "esm" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,10 @@ | ||
{ | ||
"extends": "./tsconfig.build.json", | ||
"include": ["src/**/*.ts"], | ||
"exclude": ["dist"], | ||
"extends": "../../tsconfig.json", | ||
|
||
"include": ["src/**/*"], | ||
|
||
"compilerOptions": { | ||
"rootDir": "." | ||
// package-specific options | ||
"experimentalDecorators": true | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
|
||
"include": ["test/**/*"], | ||
|
||
"compilerOptions": { | ||
// should include all types from `./tsconfig.json` plus types for all test frameworks used | ||
"types": ["jest"] | ||
|
||
// other package-specific, test-specific options | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"module": "commonjs", | ||
"outDir": "dist" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.esm.json", | ||
"extends": "./tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"baseUrl": ".", | ||
"module": "es6", | ||
"outDir": "esm" | ||
}, | ||
"include": ["src/**/*"] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
{ | ||
"extends": "./tsconfig.build.json", | ||
"include": ["src/**/*", "test/**/*"], | ||
"exclude": ["dist"], | ||
"extends": "../../tsconfig.json", | ||
|
||
"include": ["src/**/*"], | ||
|
||
"compilerOptions": { | ||
"rootDir": ".", | ||
"types": ["node", "mocha", "chai", "sinon", "jest"] | ||
// package-specific options | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
|
||
"include": ["test/**/*"], | ||
|
||
"compilerOptions": { | ||
// should include all types from `./tsconfig.json` plus types for all test frameworks used | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Would just 🔥 these comments in all of the tsconfigs, we can leave it in the template There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unlike the other comments, which I removed, these I think we should keep, because if you ever were to make changes, you'd need to know this fact. |
||
"types": ["node", "mocha", "chai", "sinon", "jest"] | ||
|
||
// other package-specific, test-specific options | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"module": "commonjs", | ||
"outDir": "dist" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.esm.json", | ||
"extends": "./tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"baseUrl": ".", | ||
"module": "es6", | ||
"outDir": "esm" | ||
}, | ||
"include": ["src/**/*"] | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
{ | ||
"extends": "./tsconfig.build.json", | ||
"include": ["src/**/*.ts", "test/**/*.ts"], | ||
"exclude": ["dist"], | ||
"extends": "../../tsconfig.json", | ||
|
||
"include": ["src/**/*"], | ||
|
||
"compilerOptions": { | ||
"rootDir": ".", | ||
"types": ["node", "jest"] | ||
// package-specific options | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
|
||
"include": ["test/**/*"], | ||
|
||
"compilerOptions": { | ||
// should include all types from `./tsconfig.json` plus types for all test frameworks used | ||
"types": ["node", "jest"] | ||
|
||
// other package-specific, test-specific options | ||
} | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"extends": "./tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"module": "commonjs", | ||
"outDir": "dist" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,8 @@ | ||
{ | ||
"extends": "../../tsconfig.esm.json", | ||
"extends": "./tsconfig.json", | ||
|
||
"compilerOptions": { | ||
"esModuleInterop": true, | ||
"baseUrl": ".", | ||
"outDir": "esm", | ||
"jsx": "react" | ||
}, | ||
"include": ["src/**/*"] | ||
"module": "es6", | ||
"outDir": "esm" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there is any place that uses them directly, let's just remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could do, but given that there's no harm in leaving it, any reason not to err on the side of caution?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if we are going back to standardize all the
package.json
eventually, we can get away with leaving it here for now.