Skip to content

build: Extract typescript pkg into main package.json #4242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2021
Merged

build: Extract typescript pkg into main package.json #4242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@
"devDependencies": {
"@angular/common": "^10.0.3",
"@angular/core": "^10.0.3",
"@angular/router": "^10.0.3",
"typescript": "3.7.5"
"@angular/router": "^10.0.3"
},
"scripts": {
"build": "run-p build:cjs build:esm",
Expand Down
1 change: 0 additions & 1 deletion packages/browser/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"rollup-plugin-terser": "^4.0.4",
"rollup-plugin-typescript2": "^0.21.0",
"sinon": "^7.3.2",
"typescript": "3.7.5",
"webpack": "^4.30.0"
},
"scripts": {
Expand Down
4 changes: 1 addition & 3 deletions packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,7 @@
"@sentry/utils": "6.16.1",
"tslib": "^1.9.3"
},
"devDependencies": {
"typescript": "3.7.5"
},
"devDependencies": {},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"devDependencies": {},

?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah this is because I just find and replaced the value. I can update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm going to leave it like this. This makes makes the diff when adding new packages much cleaner (which in turn makes git blame easier to understand in the future)

"scripts": {
"build": "run-p build:cjs build:esm",
"build:cjs": "tsc -p tsconfig.cjs.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/ember/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,7 @@
"eslint-plugin-ember": "~8.6.0",
"eslint-plugin-node": "^11.1.0",
"loader.js": "~4.7.0",
"qunit-dom": "~1.2.0",
"typescript": "3.7.5"
"qunit-dom": "~1.2.0"
},
"engines": {
"node": "10.* || >= 12"
Expand Down
3 changes: 1 addition & 2 deletions packages/eslint-config-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@
"eslint": ">=5"
},
"devDependencies": {
"eslint": "7.32.0",
"typescript": "3.7.5"
"eslint": "7.32.0"
},
"scripts": {
"link:yarn": "yarn link",
Expand Down
3 changes: 1 addition & 2 deletions packages/eslint-plugin-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
"requireindex": "~1.1.0"
},
"devDependencies": {
"mocha": "^6.2.0",
"typescript": "3.7.5"
"mocha": "^6.2.0"
},
"scripts": {
"link:yarn": "yarn link",
Expand Down
3 changes: 1 addition & 2 deletions packages/gatsby/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@
"devDependencies": {
"@sentry/types": "6.16.1",
"@testing-library/react": "^10.4.9",
"react": "^17.0.0",
"typescript": "3.7.5"
"react": "^17.0.0"
},
"scripts": {
"build": "run-p build:cjs build:esm",
Expand Down
4 changes: 1 addition & 3 deletions packages/hub/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
"@sentry/utils": "6.16.1",
"tslib": "^1.9.3"
},
"devDependencies": {
"typescript": "3.7.5"
},
"devDependencies": {},
"scripts": {
"build": "run-p build:cjs build:esm",
"build:cjs": "tsc -p tsconfig.cjs.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/integrations/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@
"rollup-plugin-commonjs": "^9.3.4",
"rollup-plugin-node-resolve": "^4.2.3",
"rollup-plugin-terser": "^4.0.4",
"rollup-plugin-typescript2": "^0.21.0",
"typescript": "3.7.5"
"rollup-plugin-typescript2": "^0.21.0"
},
"scripts": {
"build": "run-p build:cjs build:esm build:bundle",
Expand Down
4 changes: 1 addition & 3 deletions packages/minimal/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
"@sentry/types": "6.16.1",
"tslib": "^1.9.3"
},
"devDependencies": {
"typescript": "3.7.5"
},
"devDependencies": {},
"scripts": {
"build": "run-p build:cjs build:esm",
"build:cjs": "tsc -p tsconfig.cjs.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
"@types/lru-cache": "^5.1.0",
"@types/node": "~10.17.0",
"express": "^4.17.1",
"nock": "^13.0.5",
"typescript": "3.7.5"
"nock": "^13.0.5"
},
"scripts": {
"build": "run-p build:cjs build:esm",
Expand Down
3 changes: 1 addition & 2 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@
"react-router-4": "npm:[email protected]",
"react-router-5": "npm:[email protected]",
"react-test-renderer": "^16.13.1",
"redux": "^4.0.5",
"typescript": "3.7.5"
"redux": "^4.0.5"
},
"scripts": {
"build": "run-p build:cjs build:esm",
Expand Down
3 changes: 1 addition & 2 deletions packages/serverless/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@
"google-gax": "^2.9.0",
"nock": "^13.0.4",
"npm-packlist": "^2.1.4",
"read-pkg": "^5.2.0",
"typescript": "3.7.5"
"read-pkg": "^5.2.0"
},
"scripts": {
"build": "run-p build:cjs build:esm && yarn build:awslambda-layer",
Expand Down
3 changes: 1 addition & 2 deletions packages/tracing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,7 @@
"rollup-plugin-license": "^0.8.1",
"rollup-plugin-node-resolve": "^4.2.3",
"rollup-plugin-terser": "^4.0.4",
"rollup-plugin-typescript2": "^0.21.0",
"typescript": "3.7.5"
"rollup-plugin-typescript2": "^0.21.0"
},
"scripts": {
"build": "run-p build:cjs build:esm build:bundle",
Expand Down
4 changes: 1 addition & 3 deletions packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
"publishConfig": {
"access": "public"
},
"devDependencies": {
"typescript": "3.7.5"
},
"devDependencies": {},
"scripts": {
"build": "run-p build:cjs build:esm",
"build:cjs": "tsc -p tsconfig.cjs.json",
Expand Down
3 changes: 1 addition & 2 deletions packages/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@
},
"devDependencies": {
"chai": "^4.1.2",
"jsdom": "^16.2.2",
"typescript": "3.7.5"
"jsdom": "^16.2.2"
},
"scripts": {
"build": "run-p build:cjs build:esm",
Expand Down
3 changes: 1 addition & 2 deletions packages/vue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
"rollup-plugin-license": "^0.8.1",
"rollup-plugin-node-resolve": "^4.2.3",
"rollup-plugin-terser": "^4.0.4",
"rollup-plugin-typescript2": "^0.21.0",
"typescript": "3.7.5"
"rollup-plugin-typescript2": "^0.21.0"
},
"scripts": {
"build": "run-p build:cjs build:esm build:bundle",
Expand Down
3 changes: 1 addition & 2 deletions packages/wasm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@
"rollup-plugin-commonjs": "^9.3.4",
"rollup-plugin-node-resolve": "^4.2.3",
"rollup-plugin-terser": "^4.0.4",
"rollup-plugin-typescript2": "^0.21.0",
"typescript": "3.7.5"
"rollup-plugin-typescript2": "^0.21.0"
},
"scripts": {
"build": "run-p build:cjs build:esm build:bundle",
Expand Down