-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref: Refactorings for the logger to be less bloaty #4285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report
|
For some reason some tests here are constantly cancelling. Not sure what I did to get this on this PR. |
@mitsuhiko the ember test is a flake, great job on the PR ⚡ |
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Don't close plz bot. |
This makes the logger a noop for non debug bundle builds and takes out some debug logs. It also rewrites the console sandbox so it does not repatch but just disable the integrations.
This unfortunately turned a bit into yak shaving and had to pull in some unrelated changes.