Skip to content

ref: Refactorings for the logger to be less bloaty #4285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 21 commits into from

Conversation

mitsuhiko
Copy link
Contributor

@mitsuhiko mitsuhiko commented Dec 14, 2021

This makes the logger a noop for non debug bundle builds and takes out some debug logs. It also rewrites the console sandbox so it does not repatch but just disable the integrations.

This unfortunately turned a bit into yak shaving and had to pull in some unrelated changes.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2021

size-limit report

Path Base Size (7f1fe2d) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 20.35 KB 19.68 KB -3.31% 🔽
@sentry/browser - CDN Bundle (minified) 64.99 KB 62.37 KB -4.04% 🔽
@sentry/browser - Webpack 22.35 KB 22.41 KB +0.28% 🔺
@sentry/browser - Webpack - gzip = false 76.5 KB 76.42 KB -0.12% 🔽
@sentry/react - Webpack 22.38 KB 22.44 KB +0.28% 🔺
@sentry/nextjs Client - Webpack 46.49 KB 46.56 KB +0.16% 🔺
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.51 KB 28.56 KB +0.17% 🔺

@AbhiPrasad AbhiPrasad added this to the Treeshaking / Bundle Size milestone Dec 14, 2021
@mitsuhiko mitsuhiko marked this pull request as ready for review December 15, 2021 13:08
@mitsuhiko mitsuhiko requested a review from AbhiPrasad December 15, 2021 13:40
@mitsuhiko
Copy link
Contributor Author

For some reason some tests here are constantly cancelling. Not sure what I did to get this on this PR.

@JonasBa
Copy link
Member

JonasBa commented Dec 17, 2021

@mitsuhiko the ember test is a flake, great job on the PR ⚡

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2022

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@kamilogorek
Copy link
Contributor

Don't close plz bot.

@AbhiPrasad
Copy link
Member

Closing in favour of #4863. The magic string debug stuff was done in #4842

@AbhiPrasad AbhiPrasad closed this Apr 6, 2022
@AbhiPrasad AbhiPrasad deleted the feature/smol-logger branch May 30, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants