test(browser): Add integration tests to LinkedErrors #4304
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@onurtemizkan did I do this right? What do you think? |
size-limit report
|
rhcarvalho
reviewed
Dec 15, 2021
packages/integration-tests/suites/linkederrors/variablelimit/test.ts
Outdated
Show resolved
Hide resolved
…est.ts Co-authored-by: Rodolfo Carvalho <[email protected]>
|
Closing after conversation with Rodolfo. We don't need to check for cross browser behaviour here, and it's better to focus on fixing the unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To gain more confidence in #4295, I've pulled the primary
LinkedErrorslogic into integration tests.