Skip to content

feat(core): Add eventToSentryRequest test for optional event properties #4396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2022
Merged

feat(core): Add eventToSentryRequest test for optional event properties #4396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions packages/core/test/lib/request.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@ import { initAPIDetails } from '../../src/api';
import { eventToSentryRequest, sessionToSentryRequest } from '../../src/request';

const ingestDsn = 'https://[email protected]/12312012';
const ingestUrl =
const storeUrl =
'https://squirrelchasers.ingest.sentry.io/api/12312012/store/?sentry_key=dogsarebadatkeepingsecrets&sentry_version=7';
const envelopeUrl =
'https://squirrelchasers.ingest.sentry.io/api/12312012/envelope/?sentry_key=dogsarebadatkeepingsecrets&sentry_version=7';
const tunnel = 'https://hello.com/world';

Expand Down Expand Up @@ -136,7 +138,7 @@ describe('eventToSentryRequest', () => {
expect(tunnelRequest.url).toEqual(tunnel);

const defaultRequest = eventToSentryRequest(event, initAPIDetails(ingestDsn, {}));
expect(defaultRequest.url).toEqual(ingestUrl);
expect(defaultRequest.url).toEqual(envelopeUrl);
});

it('adds dsn to envelope header if tunnel is configured', () => {
Expand Down Expand Up @@ -171,6 +173,20 @@ describe('eventToSentryRequest', () => {

expect(envelope.event.processingMetadata).toBeUndefined();
});

it("doesn't depend on optional event fields for success ", () => {
// all event fields are optional
const emptyEvent = {};

const result = eventToSentryRequest(emptyEvent, api);
expect(result).toEqual({
// The body isn't empty because SDK info gets added in `eventToSentryRequest`. (The specifics of that SDK info are
// tested elsewhere.)
body: expect.any(String),
type: 'event',
url: storeUrl,
});
});
});

describe('sessionToSentryRequest', () => {
Expand Down Expand Up @@ -206,7 +222,7 @@ describe('sessionToSentryRequest', () => {
expect(tunnelRequest.url).toEqual(tunnel);

const defaultRequest = sessionToSentryRequest({ aggregates: [] }, initAPIDetails(ingestDsn, {}));
expect(defaultRequest.url).toEqual(ingestUrl);
expect(defaultRequest.url).toEqual(envelopeUrl);
});

it('adds dsn to envelope header if tunnel is configured', () => {
Expand Down