changed(tracing): always clear timeout when new activity starts within idle timeout #4450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn lint
) & (yarn test
).Summary
Always clear idle timeout when new activity starts within the idle timeout, by assigning the
popAcitivity
timeout to the instance's timeout.Example
Before
IdleTransaction
withidleTimeout
=1000
i. Idle timeout is created
i. Idle timeout is cleared
i. An unstoppable idle timeout is created
After
IdleTransaction
withidleTimeout
=1000
i. Idle timeout is created
i. Idle timeout is cleared
i. Idle timeout is created
i. Idle timeout is cleared
i. Idle timeout is created
Notes
_initTimeout
to_idleTimeout
to match its new(?) purpose more accurately.