Skip to content

chore(build): Update and hoist rollup-plugin-license #4522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

lobsterkatie
Copy link
Member

In preparation for the new bundling process, this updates rollup-plugin-license to current and pulls it into the main package.json.

Running the build with the current version and the new version results in identical bundles:

image

@@ -42,7 +42,6 @@
"playwright": "^1.17.1",
"rollup": "^1.10.1",
"rollup-plugin-commonjs": "^9.3.4",
"rollup-plugin-license": "^0.8.1",
"rollup-plugin-node-resolve": "^4.2.3",
"rollup-plugin-terser": "^4.0.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we hoist the rest of the roll-up plugins as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on it! 🙂

(Really what I'm working on is updating them one by one and making sure nothing important changes. I'll hoist each one as I update it.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lobsterkatie lobsterkatie enabled auto-merge (squash) February 8, 2022 23:54
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

size-limit report

Path Base Size (c31b4d7) Current Size Change
@sentry/browser - CDN Bundle (gzipped) 19.69 KB 19.69 KB +0.02% 🔺
@sentry/browser - CDN Bundle (minified) 62.91 KB 62.91 KB +0.01% 🔺
@sentry/browser - Webpack 22.21 KB 22.21 KB 0%
@sentry/browser - Webpack - gzip = false 76.02 KB 76.02 KB 0%
@sentry/react - Webpack 22.24 KB 22.24 KB 0%
@sentry/nextjs Client - Webpack 46.31 KB 46.31 KB 0%
@sentry/browser + @sentry/tracing - CDN Bundle (gzipped) 28.22 KB 28.23 KB +0.02% 🔺

@lobsterkatie lobsterkatie merged commit 448244b into master Feb 9, 2022
@lobsterkatie lobsterkatie deleted the kmclb-upgrade-rollup-plugin-license branch February 9, 2022 00:03
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants