feat(wasm): Add test against minified browser bundle #4526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report
|
AbhiPrasad
approved these changes
Feb 9, 2022
| // `index.html` save the browser bundle `src` value. In the long run, we should rig it so just the bundle can be | ||
| // passed in. (Or, once the new bundling process is nailed down, stop testing against the minified bundle, since | ||
| // that's not really what this test is for.) | ||
| ['index.html', 'min-bundle.html'].forEach(pagePath => |
There was a problem hiding this comment.
I was going to suggest dynamically generating these using a template, but we should wait till the new bundling process is nailed down.
There was a problem hiding this comment.
Yup, that's exactly what I meant by passing the bundle in. If we decide to keep testing against both, a template is indeed probably the easiest way to do that. I'm not 100% convinced we'll even need to/want to separately test against the minified bundle once we've solved bundling, but that's a bridge we can cross when we get there.
lobsterkatie
added a commit
that referenced
this pull request
Feb 10, 2022
The current wasm integration test uses the browser bundle, and is therefore a quick smoke test of whether the bundle is legit. At least temporarily, this makes it test against the minified bundle, too, so it can act as a similar smoke test there. This is helpful as we're changing the bundling process, as it's an extra check to make sure we haven't broken the world. Because this is a likely-temporary (ab)use of this integration test, it's done in the quickest and dirtiest way possible: the page which gets loaded is replicated, with the SDK bundle pointing to the minified version rather than the regular version. If we decide to keep testing against both bundles, we should do it in a more elegant way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current wasm integration test uses the browser bundle, and is therefore a quick smoke test of whether the bundle is legit. At least temporarily, this PR makes it test against the minified bundle, too, so it can act as a similar smoke test there. This is helpful as we're changing the bundling process, as it's an extra check to make sure we haven't broken the world.
Because this is a likely-temporary (ab)use of this integration test, it's done in the quickest and dirtiest way possible: the page which gets loaded is replicated, with the SDK bundle pointing to the minified version rather than the regular version. If we decide to keep testing against both bundles, we should do it in a more elegant way.