Skip to content

ref(build): Centralize identical CDN rollup config #4637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Feb 28, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Feb 25, 2022

There is a great deal of overlap between the rollup config files we use to generate our CDN bundles. As part of moving to the new bundling process, this pulls the most obvious pieces of shared config into a central file. (In this case, “most obvious” means that they are strictly identical across files, with no tweaks needed. A follow-up PR will handle the places where there are slight differences between one rollup config and another.)

As one would hope when moving things without changing them, there is no effect on the content of the bundles produced.

Ref: https://getsentry.atlassian.net/browse/WEB-627

@github-actions
Copy link
Contributor

size-limit report

Path Base Size (bb6f865) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.7 KB 19.7 KB -0.01% 🔽
@sentry/browser - ES5 CDN Bundle (minified) 63.31 KB 63.31 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.37 KB 18.37 KB -0.02% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 56.48 KB 56.48 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.16 KB 22.16 KB 0%
@sentry/browser - Webpack (minified) 76.18 KB 76.18 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.19 KB 22.19 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.33 KB 46.33 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.16 KB 27.15 KB -0.01% 🔽

@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Feb 28, 2022
@lobsterkatie lobsterkatie merged commit 32edb0b into master Feb 28, 2022
@lobsterkatie lobsterkatie deleted the kmclb-centralize-identical-CDN-rollup-config branch February 28, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants