Skip to content

build: Upload coverage for @sentry/browser #4648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2022
Merged

build: Upload coverage for @sentry/browser #4648

merged 1 commit into from
Mar 1, 2022

Conversation

AbhiPrasad
Copy link
Member

@sentry/browser is the only package we don't upload coverage for yet. This patch enables that.

Resolves https://getsentry.atlassian.net/browse/WEB-403

@AbhiPrasad AbhiPrasad requested review from a team, Lms24 and lobsterkatie and removed request for a team February 28, 2022 16:37
@github-actions
Copy link
Contributor

github-actions bot commented Feb 28, 2022 •
edited
Loading

size-limit report

Path Base Size (7525490) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.77 KB 19.77 KB 0%
@sentry/browser - ES5 CDN Bundle (minified) 63.47 KB 63.47 KB 0%
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.44 KB 18.44 KB -0.02% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 56.6 KB 56.6 KB 0%
@sentry/browser - Webpack (gzipped + minified) 22.2 KB 22.2 KB 0%
@sentry/browser - Webpack (minified) 76.36 KB 76.36 KB 0%
@sentry/react - Webpack (gzipped + minified) 22.23 KB 22.23 KB 0%
@sentry/nextjs Client - Webpack (gzipped + minified) 46.4 KB 46.4 KB 0%
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 27.23 KB 27.23 KB -0.01% 🔽

@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Feb 28, 2022
lobsterkatie
lobsterkatie approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@lobsterkatie lobsterkatie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This also takes us a small step closer to having a single, centralized jest config.

@AbhiPrasad AbhiPrasad merged commit e876877 into master Mar 1, 2022
@AbhiPrasad AbhiPrasad deleted the abhi-add-coverage branch March 1, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lobsterkatie lobsterkatie lobsterkatie approved these changes

@Lms24 Lms24 Awaiting requested review from Lms24 Lms24 was automatically assigned from getsentry/team-web-sdk-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Pre 7.0.0 Work
Development

Successfully merging this pull request may close these issues.
2 participants
@AbhiPrasad @lobsterkatie