Skip to content

ref(stackparse): More stack parse improvements and consolidation #4669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2022
Merged

ref(stackparse): More stack parse improvements and consolidation #4669

merged 2 commits into from
Mar 2, 2022

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 2, 2022

This PR:

  • Removes browser SDK parsers.ts and moves code to eventbuilder.ts to match node SDK
    • There is no actual parsing occurring here any more so the filename didn't make much sense
  • As per the node SDK, renames browser parsers to be more clear chrome -> chromeStackParser
  • Adds priority to all stack parsers and sorts them when creating the parser
    • This is preliminary work to allow user to configure parsers
  • Renames eventFromError to eventFromUnknownInput to match browser SDK
  • Renames extractStackFromError to parseStackFrames to match browser SDK

@timfish timfish mentioned this pull request Mar 2, 2022
Closed
15 tasks
@timfish timfish marked this pull request as ready for review March 2, 2022 12:52
AbhiPrasad
AbhiPrasad reviewed Mar 2, 2022
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 2, 2022 17:34
@AbhiPrasad AbhiPrasad merged commit 3827821 into getsentry:master Mar 2, 2022
@timfish timfish deleted the more-stackparse branch March 2, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timfish @AbhiPrasad