feat(dev): Build/test CI improvements #4739
Conversation
size-limit report
|
|
We'll have to change the |
lobsterkatie
force-pushed
the
kmclb-run-ci-on-demand
branch
from
ecf55f5 to
89ca7d9
Compare
There was a problem hiding this comment.
This looks good to me. Great idea to enable a manual dispatch of the workflow! Also, I like the naming simplification of the browser bundle integration tests.
It looks ready to 🚀 to me, once CI actually goes through (which I guess is related to @AbhiPrasad's comment on the required tests).
lobsterkatie
force-pushed
the
kmclb-run-ci-on-demand
branch
from
89ca7d9 to
6c81595
Compare
size-limit report 📦
|
|
@lobsterkatie, which tests should be required / not required now? |
The ones here whose names have been changed shouldn't be required anymore because they no longer exist under those names:
For now, I suggest we not add their replacements (and other tests which have been added in the meantime) to the required list, because instead I'd like to use this action to aggregate the results: https://github.com/lwhiteley/dependent-jobs-result-check We can set it up so that action only passes if all of the different test jobs pass, and then we can require THAT check, which will cover all 22 jobs that otherwise now need to be individually added to the required list in the GH UI (you can see them in the screenshot below, just for reference), along with the 6 that already are there, and whatever future ones we add. (As our test coverage improves, this is only going to get worse.)
|
|
I made these tests required except:
Due to renaming, I can make them required only after this PR is merged. |
lobsterkatie
force-pushed
the
kmclb-run-ci-on-demand
branch
from
6c81595 to
142578d
Compare
This makes a few changes to our "Build and Test" GHA workflow:
For mysterious reasons, occasionally pushing to a PR fails to trigger CI. On the PR it says "queued," but on the Actions page, nothing ever appears. There are also times when you might want to run CI before creating a PR. This introduces the ability to run the "Build and Test" GHA on demand. As long as a branch is pushed, it can be chosen from the dropdown and its
HEADwill be run against CI. If for whatever reason the commit you want to test has been pushed but isn't the head of a branch, its SHA can be filled in instead, and it will be used instead of the branch showing in the dropdown.The titles of the browser and tracing playwright tests are currently long enough that they are truncated in the GH UI, which obscures some of the information they contain, namely the ways in which each one differs from the others. This changes the naming scheme to be more space efficient. Also, since it helps the naming and doesn't change the test behavior, the excluded tests have been switched from
tracing_only: truetotracing_only: false. (Because thetracing_onlyvalue doesn't influence thecjsandesmtests, we exclude onetracing_onlyvalue just so as not to run the same tests twice, which means changing which one is excluded doesn't change the actual tests.)The artifacts job has been moved above all of the test-related jobs, so that all non-test-related jobs come before all test-related ones.
The original browser integration tests, the ones which existed before we adopted the playwright framework, have been renamed the "Old" tests, so it's easier to distinguish them from the new ones.