Skip to content

chore(dev): Fix inconsistencies in package.json scripts #4770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented Mar 23, 2022

This fixes a few places where various packages' package.json scripts differed from the standard pattern:

  • build:dev should always run in parallel (fixed in integrations, serverless, tracing, vue, and wasm)
  • build:dev:watch should never build bundles (fixed in tracing)
  • build:watch should always build bundles (fixed in vue and wasm)
  • build:bundle:watch should exist if build:bundle exists (fixed in wasm; this is not true of integrations, but bundle building there is handled by a script, so it's more complicated and probably not worth it until/if we ever need it)

@lobsterkatie lobsterkatie force-pushed the kmclb-make-package-json-scripts-consistent branch from 522212f to a424927 Compare March 23, 2022 18:02
@github-actions
Copy link
Contributor

github-actions bot commented Mar 23, 2022

size-limit report

Path Base Size (1852e6b) Current Size Change
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 19.66 KB 19.58 KB -0.4% 🔽
@sentry/browser - ES5 CDN Bundle (minified) 62.83 KB 62.46 KB -0.59% 🔽
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.24 KB 18.19 KB -0.29% 🔽
@sentry/browser - ES6 CDN Bundle (minified) 56.15 KB 55.96 KB -0.34% 🔽
@sentry/browser - Webpack (gzipped + minified) 22.78 KB 22.72 KB -0.24% 🔽
@sentry/browser - Webpack (minified) 80.16 KB 80.38 KB +0.28% 🔺
@sentry/react - Webpack (gzipped + minified) 22.81 KB 22.76 KB -0.24% 🔽
@sentry/nextjs Client - Webpack (gzipped + minified) 47.78 KB 47.69 KB -0.18% 🔽
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 25.53 KB 25.46 KB -0.3% 🔽
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 23.85 KB 23.81 KB -0.19% 🔽

@lobsterkatie lobsterkatie requested a review from lforst March 23, 2022 19:10
@lobsterkatie lobsterkatie merged commit 1c84fce into master Mar 24, 2022
@lobsterkatie lobsterkatie deleted the kmclb-make-package-json-scripts-consistent branch March 24, 2022 19:11
@AbhiPrasad AbhiPrasad added this to the Pre 7.0.0 Work milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants