Skip to content

fix(dev): Standardize yarn clean scripts #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

lobsterkatie
Copy link
Member

Now that we have files like rollup.config.js and jest.config.js at the package root level, it's helpful if running yarn clean doesn't delete them. This fixes that problem, and also fixes a spot where the now-defunct package-top-level esm directory was still included in a clean script.

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 20.07 KB (-0.37% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 64.28 KB (-0.51% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 18.77 KB (-0.46% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 57.67 KB (-0.52% 🔽)
@sentry/browser - Webpack (gzipped + minified) 23.05 KB (-0.82% 🔽)
@sentry/browser - Webpack (minified) 80.87 KB (-1.03% 🔽)
@sentry/react - Webpack (gzipped + minified) 23.09 KB (-0.81% 🔽)
@sentry/nextjs Client - Webpack (gzipped + minified) 47.86 KB (-0.41% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 26.01 KB (-0.24% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 24.42 KB (-0.26% 🔽)

@lobsterkatie lobsterkatie merged commit 7fa3e8c into 7.x Apr 11, 2022
@lobsterkatie lobsterkatie deleted the kmclb-standardize-yarn-clean-scripts branch April 11, 2022 13:10
@AbhiPrasad AbhiPrasad added this to the 7.0.0 milestone Apr 11, 2022
Lms24 pushed a commit that referenced this pull request Apr 26, 2022
Now that we have files like `rollup.config.js` and `jest.config.js` at the package root level, it's helpful if running `yarn clean` doesn't delete them. This fixes that problem, and also fixes a spot where the now-defunct package-top-level `esm` directory was still included in a `clean` script.
lobsterkatie added a commit that referenced this pull request Apr 26, 2022
Now that we have files like `rollup.config.js` and `jest.config.js` at the package root level, it's helpful if running `yarn clean` doesn't delete them. This fixes that problem, and also fixes a spot where the now-defunct package-top-level `esm` directory was still included in a `clean` script.
lobsterkatie added a commit that referenced this pull request Apr 26, 2022
Now that we have files like `rollup.config.js` and `jest.config.js` at the package root level, it's helpful if running `yarn clean` doesn't delete them. This fixes that problem, and also fixes a spot where the now-defunct package-top-level `esm` directory was still included in a `clean` script.
AbhiPrasad pushed a commit that referenced this pull request May 30, 2022
Now that we have files like `rollup.config.js` and `jest.config.js` at the package root level, it's helpful if running `yarn clean` doesn't delete them. This fixes that problem, and also fixes a spot where the now-defunct package-top-level `esm` directory was still included in a `clean` script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants